Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roland DJ-505: Map buttons for library sorting #2125

Merged

Conversation

Holzhaus
Copy link
Member

Maps the library sort buttons on the Roland DJ-505. Depends on #2118.

@uklotzde uklotzde added this to the 2.3.0 milestone May 26, 2019
@Holzhaus Holzhaus force-pushed the roland-dj-505-mapping-library-sort branch from ba3e01f to 7bd0f22 Compare May 30, 2019 19:58
@Holzhaus
Copy link
Member Author

Holzhaus commented Jun 1, 2019

FYI I updated the column indices to match the new implementation in PR #2118, so this is ready to be merged as soon as #2118 is in master.

@Holzhaus Holzhaus force-pushed the roland-dj-505-mapping-library-sort branch from 7bd0f22 to 5ea3827 Compare June 6, 2019 14:52
@Holzhaus
Copy link
Member Author

Just retested with latest master, this is ready for merging.

@uklotzde
Copy link
Contributor

LGTM. Thank you, also for implementing the foundation!

@uklotzde uklotzde merged commit e2897ad into mixxxdj:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants