round BPM values from analyzer #2668
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the analyzed bpm is not a round number within a reasonable margin, check if 2/3, 3/2 or twice the bpm is a round number within reasonable range. This fixes most cases where the bpm is reported as 96.666 or similar, highly unlikely numbers. cleanup whitespaces
Before commit ae392c9 it was very easy to spot wrong BPM value by the fact they where odd looking. The new behaviour rounded 100.012232 to 100.0 so there was no way to see if a number is odd in the first place without hovering or editing. Now the track list will use 2 decimal points if there is a rounding error introduced, making it easy to spot odd or wrong BPMs.
If the error of rounding is very small, it makes sense to round the scaling bpm errors, which is a common error from the bpm analysis.
|
Only try a round bpm on electronic music |
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
bot
added
the
stale
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset fixes some long standing annoyances regarding bpm.
Especially often in psytrance and similar music, the analyzer returns BPM like 96.66667 and other, highly unlikely bpm numbers. If 2/3, 3/2 or 2 the bpm value results in a round number, use this bpm value instead. Testing this on ~3.000 songs reduced the error rate from 300 to ~20.
Display 2 decimal points the the BPM column if there is information loss through rounding. This helps to spot strange/wrong BPMs that are hidden since the rounding was introduced.
Round the BPM on scaling operations if the number is nearly round.