Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some skin internals from DlgPrefInterface #3891

Merged
merged 13 commits into from
May 26, 2021
Merged

Remove some skin internals from DlgPrefInterface #3891

merged 13 commits into from
May 26, 2021

Commits on May 25, 2021

  1. skin/legacy: Add Skin abstraction

    @Holzhaus
    Holzhaus committed May 25, 2021
    Configuration menu
    Copy the full SHA
    f287998 View commit details
    Browse the repository at this point in the history

  2. DlgPrefInterface: Use QMap of skins

    @Holzhaus
    Holzhaus committed May 25, 2021
    Configuration menu
    Copy the full SHA
    e596e51 View commit details
    Browse the repository at this point in the history

  3. DlgPrefInterface: Remove unused parameter from slotSetSkinDescription

    @Holzhaus
    Holzhaus committed May 25, 2021
    Configuration menu
    Copy the full SHA
    4675b64 View commit details
    Browse the repository at this point in the history

  4. DlgPrefInterface: Make some slots private

    @Holzhaus
    Holzhaus committed May 25, 2021
    Configuration menu
    Copy the full SHA
    c4357ca View commit details
    Browse the repository at this point in the history

  5. SkinLoader: Avoid detach of Qt container in range loop

    @Holzhaus
    Holzhaus committed May 25, 2021
    Configuration menu
    Copy the full SHA
    b03a419 View commit details
    Browse the repository at this point in the history

  6. Skin: Add default constructor and add validity checks

    @Holzhaus
    Holzhaus committed May 25, 2021
    Configuration menu
    Copy the full SHA
    6f56f2e View commit details
    Browse the repository at this point in the history

  7. Skin: Add preview() method to retrieve preview image

    @Holzhaus
    Holzhaus committed May 25, 2021
    Configuration menu
    Copy the full SHA
    ab8347d View commit details
    Browse the repository at this point in the history

  8. Skin: Add abstract base class for LegacySkin

    @Holzhaus
    Holzhaus committed May 25, 2021
    Configuration menu
    Copy the full SHA
    3a8effa View commit details
    Browse the repository at this point in the history

  9. SkinLoader: Pass CoreServices to loadConfiguredSkin

    @Holzhaus
    Holzhaus committed May 25, 2021
    Configuration menu
    Copy the full SHA
    d50070a View commit details
    Browse the repository at this point in the history

  10. SkinLoader: Move actual loader implementation into LegacySkin class

    @Holzhaus
    Holzhaus committed May 25, 2021
    Configuration menu
    Copy the full SHA
    728fcbd View commit details
    Browse the repository at this point in the history

  11. SkinLoader: Move more legacy skin internals out of SkinLoader class

    @Holzhaus
    Holzhaus committed May 25, 2021
    Configuration menu
    Copy the full SHA
    649feaf View commit details
    Browse the repository at this point in the history

  12. SkinLoader: Move class into mixxx::skin:: namespace

    @Holzhaus
    Holzhaus committed May 25, 2021
    Configuration menu
    Copy the full SHA
    512ca67 View commit details
    Browse the repository at this point in the history

  13. SkinLoader: Improve error handling (add fallback if skin is broken)

    @Holzhaus
    Holzhaus committed May 25, 2021
    Configuration menu
    Copy the full SHA
    b94d0ee View commit details
    Browse the repository at this point in the history