Beat count to next cue

[jmmaldonado]

Adds a beat counter from the current play position to the nearest cue point
The information is displayed in the deck time widget
Created a new option when selecting the time display for the decks so you can choose to show the information or keep the traditional deck time information.

[JoergAtGithub]

This works for me, and it is a helpful addition!
Some things I noticed:

• The option in the preferences is always "Elapsed", after reopening the Preference dialog.
• If the loop is placed before the next cue point, it counts down until this loop (is this bug or feature?)
• After the last cue point, just "beats" is shown (wouldn't it help to count beats until track end?)

[jmmaldonado]

Thanks for the feedback Joerg ! Glad you find it useful too :)

• I didn't notice that, it is true I didn't re-open the preferences dialog right away but rather after closing and re-launching mixxx, in this case the setting persisted, but will take a look at the preferences dialog
• I would say bug, definitely not what I intended, I would need to filter down on the specific Cue point type ... unless you find this useful, happy to discuss further :)
• I added a different text message, perhaps I forgot to push it, but you are right ... instead of "no cues left", the countdown to the outro would be better

Thanks for taking a look !

[Be-ing]

Please post screenshots when you modify the GUI

[jmmaldonado]

Preferences dialog

[jmmaldonado]

Beat counter UI

[daschuer]

Thank you, I like the idea.

Mixxx uses ControlObjects to communicate between different parts and the GUI or controller scrips.

This is also done for the "time_remaining"

mixxx/src/widget/wnumberpos.cpp

Line 21 in 4637d7c

m_pTimeRemaining = new ControlProxy(

To follow this pattern, I suggest to create a new ControlObject for your purpose. That can be written in DeckVisuals::process() for instance.

[JoergAtGithub]

To fix the Pre-Commit issue, you can download the file pre-commit.patch from the Github artifacts, unzip it in your Mixxx directory, and call git apply pre-commit.patch
This works also on Windows.

[jmmaldonado]

Thank you everyone for your help here, first time contributing so lots of room for learning and improving !
I will take a look to all the feedback provided and move to a ControlObject implementation as soon as I can

In terms of the UI, having the beat count in the track time widget was more like a proof of concept than anything else, I think I would rather have that counter directly over the play head in the waveform, but this may be too much of a UI change. WDYT ?

[Be-ing]

Have you considered putting this information in the text that appears when hovering cue points on the overview waveform instead? Are you sure you'd want to see this all the time? I'd imagine it would get kinda annoying when you don't have a bunch of cues on a track.

[jmmaldonado]

Have you considered putting this information in the text that appears when hovering cue points on the overview waveform instead? Are you sure you'd want to see this all the time? I'd imagine it would get kinda annoying when you don't have a bunch of cues on a track.

To my style of mixing having this information always visible and at hand is essential, maybe having it on the waveform could be overkill for most people but if we go that route there should be a preferences option to show / hide that info.
In the meantime I believe having the beat counter in the track time widget is not very intrusive and as it is right now you can always fall back to the traditional elapsed / remaining / elapsed + remaining setting

What I was thinking about is something like rekordbox displays on top of the waveform, I use it extensively in my sets

[JoergAtGithub]

For me, the feature makes only sense, if it's always visible.
I recommend to keep this initial PR simple, you can improve it in follow-up PRs.

[jmmaldonado]

Makes sense, I will make sure the PR works with the current way of getting the play position (and it passes all the tests!) and then iterate to move to COs and start improving from there. Thanks !

[ronso0]

Just some findings in the pref ui file.

[jmmaldonado]

I think I finally got clang-format working on windows, so hopefully no more code style errors
Trying now to get clazy to work as well, but at least I fixed the errors shown in the last build
Apologies for all the coming back & forth with this

[ronso0]

Please check the CI tests:
There is a typo https://github.com/mixxxdj/mixxx/runs/6975409044?check_suite_focus=true#step:5:92
and some clazy error https://github.com/mixxxdj/mixxx/runs/6975409048?check_suite_focus=true#step:9:486

[ronso0]

To the see the beats countdown I'd need to select ".. Remaining", though I'd appreciate if the the beat countdown would be a independent option (checkbox below the time display row).
What do others think?

[jmmaldonado]

Please check the CI tests: There is a typo https://github.com/mixxxdj/mixxx/runs/6975409044?check_suite_focus=true#step:5:92 and some clazy error https://github.com/mixxxdj/mixxx/runs/6975409048?check_suite_focus=true#step:9:486

Will take a look right away, thanks !

To the see the beats countdown I'd need to select ".. Remaining", though I'd appreciate if the the beat countdown would be a independent option (checkbox below the time display row). What do others think?

Re-reading the comment I see what you mean, so a separate option to decide whether to show it or not, but then keep it displayed on the track time counters, right?
in any case, for the future of the feature I think I will branch from what we have today and try to display it on top of the waveform as other software do, with a checkbox to select if we want it on display or not. In terms of feature design is at least what I would expect, and more convenient to sync the beat counters between tracks (less eye travel time to ensure they are in sync)

[ronso0]

Re-reading the comment I see what you mean, so a separate option to decide whether to show it or not, but then keep it displayed on the track time counters, right?

Jep, that's what I mean.
Maybe the pos display widget (max) size needs to be adjusted in skins.

display it on top of the waveform as other software do, with a checkbox to select if we want it on display or not.

Sounds good.
Please check with more than on skin when you test it. Skins show all sorts of markers in different positions (cue, hotcue, loops, intro, outro : left|right, top|center|bottom), and there will hopefully be a way to display the [remaining beats] without obscurring other potentially more relevant information.

[jmmaldonado]

Re-reading the comment I see what you mean, so a separate option to decide whether to show it or not, but then keep it displayed on the track time counters, right?

Jep, that's what I mean. Maybe the pos display widget (max) size needs to be adjusted in skins.

I will finish the feature with the comments you made about having the option as an independent checkbox so we have it ready to merge if we want to, and then move to the advanced visualization on the waveform. As you said, it will probably take us more iterations to decide whether it is the right place to show or not

[github-actions]

This PR is marked as stale because it has been open 90 days with no activity.

[tippfehlr]

Not exactly this PR but I would find it helpful to display the beat count along with the time on intro/outro sections

[JoergAtGithub]

Not exactly this PR but I would find it helpful to display the beat count along with the time on intro/outro sections

Make sense to me

[ejgutierrez74]

When we are going to see this feature perhaps optional ( preference settings):

I suppose it would come with 2.3.6 ? Perhaps in 2.4 ? Or it would never came to mixxx ?

Thanks

[ronso0]

2.3.6 was released today, 2.4 will come during the next few weeks.

If someone finishes / adopts this stale PR there's a foundation for other display options.

[ejgutierrez74]

2.3.6 was released today, 2.4 will come during the next few weeks.

If someone finishes / adopts this stale PR there's a foundation for other display options.

But you have to approve the changes

In history seems that jmaldonado made the changes you ask for a year ago or so....

Seems not very difficult to implement this.

Thanks for your answer

[ronso0]

Nope, the separate preference checkbox has not been implemented, yet.

Re-reading the comment I see what you mean, so a separate option to decide whether to show it or not, but then keep it displayed on the track time counters, right?

2.4 feature freeze has long passed, so this will go to 2.5 soonest.

@jmmaldonado Do you intend (and have time) to finish this?

[jmmaldonado]

I definitely want to get back to it - and get the dev env up again, had to tear it down - no ETA I can commit to though :(

In the meantime @ejgutierrez74 if you want to try it as it is right now with the basic functionality working but not very well integrated in the UI, you can build from the fork in my repo and see how it goes, we could use your comments and help with the implementation if you are up for it too

[mxmilkiib]

This was superseded by #12994, yes?

[ronso0]

I think so, yes.
Closing this to clean up the PR list.
Feel free to adopt / reopen.