Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CachingReader: Reduce log spam for corrupt files #652

Merged
merged 27 commits into from
Jul 28, 2015
Merged

CachingReader: Reduce log spam for corrupt files #652

merged 27 commits into from
Jul 28, 2015

Commits on Jul 17, 2015

  1. Use an exclusive upper bound for frame indexes 

    start/end = inclusive/exclusive
first/last = inclusive/inclusive
    @uklotzde
    uklotzde committed Jul 17, 2015
    Configuration menu
    Copy the full SHA
    a453bb1 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2015

  1. Shorten readable length of corrupt files to avoid repeated decoding

    @uklotzde
    uklotzde committed Jul 18, 2015
    Configuration menu
    Copy the full SHA
    10d1a08 View commit details
    Browse the repository at this point in the history

  2. Add a function to clamp a frame index interval

    @uklotzde
    uklotzde committed Jul 18, 2015
    Configuration menu
    Copy the full SHA
    946f914 View commit details
    Browse the repository at this point in the history

  3. No need to allocate CachingReaderWorker dynamically

    @uklotzde
    uklotzde committed Jul 18, 2015
    Configuration menu
    Copy the full SHA
    95686a7 View commit details
    Browse the repository at this point in the history

  4. Define a constant for special hint length values

    @uklotzde
    uklotzde committed Jul 18, 2015
    Configuration menu
    Copy the full SHA
    5eff211 View commit details
    Browse the repository at this point in the history

  5. Code cleanups: Consistent naming, remove unncessary checks and local … 

    …variables, ...
    @uklotzde
    uklotzde committed Jul 18, 2015
    Configuration menu
    Copy the full SHA
    e86957f View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2015

  1. Fill sample buffer with zeros if data is unreadable

    @uklotzde
    uklotzde committed Jul 20, 2015
    Configuration menu
    Copy the full SHA
    e037f3a View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2015

  1. Add note about outdated/imprecise comment 

    ...to trigger a Travis CI rebuild after a strange test failure ;)
    @uklotzde
    uklotzde committed Jul 21, 2015
    Configuration menu
    Copy the full SHA
    ed1912f View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2015

  1. Fix preroll calculation in CachingReader

    @uklotzde
    uklotzde committed Jul 23, 2015
    Configuration menu
    Copy the full SHA
    d86cac0 View commit details
    Browse the repository at this point in the history

  2. Delete unused members from cached chunks

    @uklotzde
    uklotzde committed Jul 23, 2015
    Configuration menu
    Copy the full SHA
    4a0c4ca View commit details
    Browse the repository at this point in the history

  3. Stop reading on errors

    @uklotzde
    uklotzde committed Jul 23, 2015
    Configuration menu
    Copy the full SHA
    5360eb9 View commit details
    Browse the repository at this point in the history

  4. Adjust upper chunk bound on errors

    @uklotzde
    uklotzde committed Jul 23, 2015
    Configuration menu
    Copy the full SHA
    f9e1d19 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2015

  1. Split CachingReader::read() into 3 phases and add helpful comments

    @uklotzde
    uklotzde committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    0ec591e View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2015

  1. Delete obsolete forward declaration

    @uklotzde
    uklotzde committed Jul 25, 2015
    Configuration menu
    Copy the full SHA
    4ea5ec9 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2015

  1. Introduce class CachingReaderChunk

    @uklotzde
    uklotzde committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    b485ee4 View commit details
    Browse the repository at this point in the history

  2. Simplify CachingReader(-Worker) by using CachingReaderChunk

    @uklotzde
    uklotzde committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    0ecc591 View commit details
    Browse the repository at this point in the history

  3. Implement fault tolerant seeking

    @uklotzde
    uklotzde committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    0b5ed8f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into ReduceLogSpamForCorruptFiles

    @uklotzde
    uklotzde committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    45a0c63 View commit details
    Browse the repository at this point in the history

  5. Split CachingReaderChunk into 2 classes (cache vs. worker)

    @uklotzde
    uklotzde committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    7c37e39 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2015

  1. Fix some minor review comments

    @uklotzde
    uklotzde committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    bdc32ea View commit details
    Browse the repository at this point in the history

  2. Renaming: CachingReaderChunkWorker -> CachingReaderChunkForWorker

    @uklotzde
    uklotzde committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    418b4c7 View commit details
    Browse the repository at this point in the history

  3. Rename functions for passing control between cache and worker

    @uklotzde
    uklotzde committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    18a1a23 View commit details
    Browse the repository at this point in the history

  4. Add more comments to the worker that explain the reading strategy

    @uklotzde
    uklotzde committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    8c5ac9f View commit details
    Browse the repository at this point in the history

  5. Re-adjust max. readable frame index after reading

    @uklotzde
    uklotzde committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    7bb596e View commit details
    Browse the repository at this point in the history

  6. Disable implicit copy-ctor of CachingReaderChunkForWorker

    @uklotzde
    uklotzde committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    c7a23b7 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2015

  1. Renaming: CachingReaderChunkForWorker/CachingReaderChunkForOwner

    @uklotzde
    uklotzde committed Jul 28, 2015
    Configuration menu
    Copy the full SHA
    3ec2db9 View commit details
    Browse the repository at this point in the history

  2. Improve processing of requests in CachingReaderWorker

    @uklotzde
    uklotzde committed Jul 28, 2015
    Configuration menu
    Copy the full SHA
    ecba2aa View commit details
    Browse the repository at this point in the history