Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to ESM #84

Closed
wants to merge 36 commits into from
Closed

Move to ESM #84

wants to merge 36 commits into from

Conversation

mizdra
Copy link
Owner

@mizdra mizdra commented Dec 13, 2021

No description provided.

@mizdra
Copy link
Owner Author

mizdra commented Dec 13, 2021

cli-table and is-installed-globally will fail to compile because they do not provide an ESM. There is nothing I can do...?

> yarn run lint:tsc:src
yarn run v1.22.15
$ tsc -p tsconfig.src.json --noEmit
src/formatter/format-by-rules.ts:2:19 - error TS2307: Cannot find module 'cli-table' or its corresponding type declarations.

2 import Table from 'cli-table';
                    ~~~~~~~~~~~

src/index.ts:2:33 - error TS2307: Cannot find module 'is-installed-globally' or its corresponding type declarations.

2 import isInstalledGlobally from 'is-installed-globally';
                                  ~~~~~~~~~~~~~~~~~~~~~~~


Found 2 errors in 2 files.

Errors  Files
     1  /Users/mizdra/src/github.com/mizdra/eslint-interactive/src/formatter/format-by-rules.ts:2
     1  /Users/mizdra/src/github.com/mizdra/eslint-interactive/src/index.ts:2
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@mizdra
Copy link
Owner Author

mizdra commented Dec 18, 2021

Some actions (disablePerLine, disablePerFile, applySuggestions) is failed because dist/rules/transform.cjs is ignored by this codes...

@mizdra mizdra closed this Dec 18, 2021
@mizdra mizdra deleted the use-module-node12 branch December 18, 2021 09:41
@mizdra mizdra restored the use-module-node12 branch December 19, 2021 16:00
This was referenced Dec 27, 2021
@mizdra mizdra changed the title Use module: node12 in tsconfig.json Move to ESM Dec 28, 2021
@mizdra mizdra deleted the use-module-node12 branch December 31, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant