-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to ESM #84
Closed
Closed
Move to ESM #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli-table and is-installed-globally will fail to compile because they do not provide an ESM. There is nothing I can do...? > yarn run lint:tsc:src
yarn run v1.22.15
$ tsc -p tsconfig.src.json --noEmit
src/formatter/format-by-rules.ts:2:19 - error TS2307: Cannot find module 'cli-table' or its corresponding type declarations.
2 import Table from 'cli-table';
~~~~~~~~~~~
src/index.ts:2:33 - error TS2307: Cannot find module 'is-installed-globally' or its corresponding type declarations.
2 import isInstalledGlobally from 'is-installed-globally';
~~~~~~~~~~~~~~~~~~~~~~~
Found 2 errors in 2 files.
Errors Files
1 /Users/mizdra/src/github.com/mizdra/eslint-interactive/src/formatter/format-by-rules.ts:2
1 /Users/mizdra/src/github.com/mizdra/eslint-interactive/src/index.ts:2
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. |
- `jest.requireActual` do not be supported in ESM - ref: jestjs/jest#9430 (comment) - So, `test/formatter/index.test.ts` do not work. - I decided to delete this test file since it is not needed in the first place.
mizdra
force-pushed
the
use-module-node12
branch
from
December 13, 2021 15:35
98f6278
to
24e64f0
Compare
mizdra
force-pushed
the
use-module-node12
branch
from
December 18, 2021 08:27
0bea23f
to
d14cf23
Compare
Some actions (disablePerLine, disablePerFile, applySuggestions) is failed because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.