Enable macro unit tests #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mjirv , |
|
@LeopoldGabelmann thanks for submitting this! I think it's a great idea. I'm taking a closer look, but would you mind adding something to the README about this option so people know it exists? Thanks for adding tests btw. |
LeopoldGabelmann
force-pushed
the
enable_macro_unit_tests
branch
2 times, most recently
from
0405e14
to
d645685
Compare
LeopoldGabelmann
force-pushed
the
enable_macro_unit_tests
branch
from
d645685
to
315db53
Compare
Replaced the original code inside the test blocks with the new macros.
LeopoldGabelmann
force-pushed
the
enable_macro_unit_tests
branch
from
315db53
to
441f82e
Compare
This has to be done for the values and the keys. This is necessary so that the unit tests can be executed as macros.
LeopoldGabelmann
force-pushed
the
enable_macro_unit_tests
branch
from
441f82e
to
5d3b4e3
Compare
|
@mjirv - You're right, I should have added some explanation to the README on how to use this. I have done so now :) |
|
@mjirv friendly reminder :) |
mjirv
approved these changes
Jul 3, 2023
mjirv
added a commit
that referenced
this pull request
Jul 3, 2023
* added incremental model and test * working code for incremental tests -- old unit test still works * working code for incremental tests -- old unit test still works * updated comments * moved unit test incremental to its own method * moved unit test incremental to its own method * updates readme and version for incremental tests * Enable macro unit tests (#79) * Added all existing unit tests in macro form. * Refactored the test blocks into macros blocks. Replaced the original code inside the test blocks with the new macros. * Adjusted the render logic for the the input mapping. This has to be done for the values and the keys. This is necessary so that the unit tests can be executed as macros. * Added explanations to the README on how to setup the tests as macros. --------- Co-authored-by: Leopold Gabelmann <[email protected]> * fixes merge issues * minor fixes * oops * thought i got rid of that already * o i see * adds exclude_columns * adds exclude_columns to test * bumps versions --------- Co-authored-by: Petter Söderlund <[email protected]> Co-authored-by: Leopold Gabelmann <[email protected]> Co-authored-by: Leopold Gabelmann <[email protected]>
| {% macro __set_rendered_keys(ns, keys) %} | ||
| {% for k in keys %} | ||
| {% do ns.rendered_keys.update({k: render("{{ " + k + " }}")}) %} | ||
| {% macro __set_rendered_mappings(ns, input_mapping) %} |
There was a problem hiding this comment.
FYI: This forces the ref in the sql files and the yml files to be EXACTLY the same
Open
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a:
Description & motivation
Within our team our yml for our dpt project got quite large. If one uses a lot of data tests, documents every column (even if it is centralized using docs) and then adds all the unit tests on top of it, it can be a lot of lines. Therefore, we were looking for a way to outsource all our unit tests inside of macros.
This has the additional benefit that it is very easy to run single a unit test while coding and controlling for possible errors. Furthermore, this makes it possible to run all data and unit tests apart from each other (e.g. in a CI/CD Pipeline) by selecting/excluding all unit tests via their folder path in tests.
Checklist