-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mjmlconfig #1206
Mjmlconfig #1206
Conversation
packages/mjml-cli/src/client.js
Outdated
@@ -83,14 +83,19 @@ export default async () => { | |||
type: 'object', | |||
describe: 'Option to pass to mjml-core', | |||
}, | |||
cp: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--config.configPath
will be already defined, I think available options should only be listed in --config option instead
Hey ! That looks really great for me ! Just I would stick to current |
Here's my test repo: https://github.com/jskrzypek/mjml-config-test-project |
@iRyusa if there are any other changes you'd like me to make on this pr, just let me know 😄 |
HI @jskrzypek We just freeze our dev on 4.1 so it will be merged for a 4.1.1 👌 |
@jskrzypek nice PR, i'll merge it right now. I'll just change the option name |
@kmcb777 @iRyusa Following up on our discussion from #1131
I included a couple enhancements that seemed to make sense:
"mjml-chart"
rather than"./node_modules/mjml-chart/lib/index.js"
). I handle scenarios where this fails to resolve correctly.packages
array resolve to a non-callable object whose properties are components (likemjml-accordion
does), I iterate over the keys of the object and register the callable component classes insteadI'm going to create a simple test project and make sure this will work with mjml-charts and an additional custom component and then link the repo here so you guys can verify