[Refactor]Complete #110
Merged
[Refactor]Complete #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Refactor]Apply
ndaemy
requested changes
May 8, 2024
src/pages/Apply.tsx
Outdated
| '서버에 이슈가 있습니다. 문제가 지속될 경우 메인 홈페이지의 채팅을 통해 관리자에게 문의해주세요.', | ||
| ); | ||
| } | ||
| setIsLoading(false); |
There was a problem hiding this comment.
지금은 에러나는 경우에만 setIsLoading(false); 가 실행되고 있습니다. 오히려 정상적인 경우에는 loading 이 무제한으로 걸리고 있어요. 수정될 필요가 있습니다
finally 를 찾아보시는 것도 도움이 될거에요
There was a problem hiding this comment.
말씀해주신대로 반영을 해서 수정해봤읍니다 ,,,!! 여유있으실 때 확인해주시면 감사하겠습니다 선생림!!🥹👍🏻
Bhanjo
reviewed
May 12, 2024
src/styles/index.tsx
Outdated
Comment on lines
1
to
15
| import { colors } from './colors'; | ||
| import { size } from './size'; | ||
| import { typographies } from './typographies'; | ||
|
|
||
| export const theme = { | ||
| colors, | ||
| size, | ||
| typographies, | ||
| }; | ||
|
|
||
| export type Theme = typeof theme; | ||
|
|
||
| export * from './colors'; | ||
| export * from './size'; | ||
| export * from './typographies'; |
There was a problem hiding this comment.
이걸 해석해보면 colors, size, typographies는 blue, theme.blue 두 방식으로 참조 가능할 것 같은데 맞나요?
ndaemy
approved these changes
May 21, 2024
Comment on lines
+13
to
+15
| export * from './colors'; | ||
| export * from './size'; | ||
| export * from './typographies'; |
There was a problem hiding this comment.
한조도 리뷰 남겼던 것 같은데, 얘네는 혹시 어떤 의도에요?
There was a problem hiding this comment.
한 곳에서 관리하려던 의도였습니당...ㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝Summary
Apply 페이지와 관련한 컴포넌트 및 style을 TypeScript로 리팩토링