Skip to content

Commit

Permalink
[Hub Generated] Review request for Microsoft.Advisor to add version s…
Browse files Browse the repository at this point in the history 
…table/2020-01-01 (Azure#13177)

* Update advisor.json

Add additional property

* Update GetRecommendationDetail.json

* Update ListRecommendations.json

* Update GetRecommendationDetail.json

* Update advisor.json

* move property to botton
  • Loading branch information
@mudit794 @mkarmark
mudit794 authored and mkarmark committed Jul 20, 2021
1 parent 6702ce5 commit f56f23e
Show file tree
Hide file tree
Showing 3 changed files with 149 additions and 6 deletions.
55 changes: 55 additions & 0 deletions specification/advisor/resource-manager/Microsoft.Advisor/stable/2020-01-01/advisor.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1136,6 +1136,46 @@
"resourceMetadata": {
"$ref": "#/definitions/ResourceMetadata",
"description": "Metadata of resource that was assessed"
},
"description": {
"description": "The detailed description of recommendation.",
"type": "string"
},
"label": {
"description": "The label of recommendation.",
"type": "string"
},
"learnMoreLink": {
"description": "The link to learn more about recommendation and generation logic.",
"type": "string"
},
"potentialBenefits": {
"description": "The potential benefit of implementing recommendation.",
"type": "string"
},
"actions": {
"description": "The list of recommended actions to implement recommendation.",
"type": "array",
"items": {
"type": "object",
"additionalProperties": {
"type": "object"
}
}
},
"remediation": {
"description": "The automated way to apply recommendation.",
"type": "object",
"additionalProperties": {
"type": "object"
}
},
"exposedMetadataProperties": {
"description": "The recommendation metadata properties exposed to customer to provide additional information.",
"type": "object",
"additionalProperties": {
"type": "object"
}
}
}
},
Expand Down Expand Up @@ -1185,6 +1225,21 @@
"source": {
"description": "Source from which recommendation is generated",
"type": "string"
},
"action": {
"description": "The action to view resource.",
"type": "object",
"additionalProperties": {
"type": "object"
}
},
"singular": {
"description": "The singular user friendly name of resource type. eg: virtual machine",
"type": "string"
},
"plural": {
"description": "The plural user friendly name of resource type. eg: virtual machines",
"type": "string"
}
}
},
Expand Down
35 changes: 33 additions & 2 deletions ...esource-manager/Microsoft.Advisor/stable/2020-01-01/examples/GetRecommendationDetail.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,41 @@
"problem": "Monitoring agent is not installed on your machines",
"solution": "Monitoring agent should be installed on your machines"
},
"remediation": {
"httpMethod": "POST",
"uri": "uri",
"details": "link to document"
},
"resourceMetadata": {
"resourceId": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/virtualMachines/xyz",
"source": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/virtualMachines/xyz/providers/Microsoft.Security/assessments/assessmentGuid"
}
"source": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/virtualMachines/xyz/providers/Microsoft.Security/assessments/assessmentGuid",
"action": {
"actionType": "Document",
"link": "https://link3",
"caption": "Enable Soft Delete to protect blob data",
"description": "Enable Soft Delete to protect blob data",
"metadata": {
"id": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/virtualMachines/xyz"
}
},
"singular": "Virtual machine",
"plural": "Virtual machines"
},
"actions": [
{
"actionType": "Document",
"link": "https://link1",
"caption": "Enable Soft Delete to protect blob data",
"description": "Enable Soft Delete to protect blob data",
"metadata": {
"id": "/subscriptions/subscriptionId"
}
}
],
"description": "After enabling Soft Delete, deleted data transitions to a soft deleted state instead of being permanently deleted. When data is overwritten, a soft deleted snapshot is generated to save the state of the overwritten data. You can configure the amount of time soft deleted data is recoverable before it permanently expires.",
"label": "Enable Soft Delete",
"learnMoreLink": "https://link2",
"potentialBenefits": "Save and recover your data when blobs or blob snapshots are accidentally overwritten or deleted"
},
"type": "Microsoft.Advisor/recommendations"
}
Expand Down
65 changes: 61 additions & 4 deletions ...or/resource-manager/Microsoft.Advisor/stable/2020-01-01/examples/ListRecommendations.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,44 @@
"impactedValue": "armavset",
"lastUpdated": "2017-02-24T22:24:43.3216408Z",
"risk": "Warning",
"remediation": {
"httpMethod": "POST",
"uri": "uri",
"details": "link to document"
},
"shortDescription": {
"problem": "This availability set is not configured for fault tolerance",
"solution": "To ensure high availability add one or more virtual machines to this availability set"
},
"resourceMetadata": {
"resourceId": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/availabilitysets/abc"
}
"resourceId": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/availabilitysets/abc",
"action": {
"actionType": "Document",
"link": "https://link3",
"caption": "Enable Soft Delete to protect blob data",
"description": "Enable Soft Delete to protect blob data",
"metadata": {
"id": "/subscriptions/subscriptionId"
}
},
"singular": "Availability set",
"plural": "Availability sets"
},
"actions": [
{
"actionType": "Document",
"link": "https://link1",
"caption": "Enable Soft Delete to protect blob data",
"description": "Enable Soft Delete to protect blob data",
"metadata": {
"id": "/subscriptions/subscriptionId"
}
}
],
"description": "After enabling Soft Delete, deleted data transitions to a soft deleted state instead of being permanently deleted. When data is overwritten, a soft deleted snapshot is generated to save the state of the overwritten data. You can configure the amount of time soft deleted data is recoverable before it permanently expires.",
"label": "Enable Soft Delete",
"learnMoreLink": "https://link2",
"potentialBenefits": "Save and recover your data when blobs or blob snapshots are accidentally overwritten or deleted"
},
"type": "Microsoft.Advisor/recommendations"
},
Expand All @@ -45,8 +76,34 @@
},
"resourceMetadata": {
"resourceId": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/virtualMachines/xyz",
"source": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/virtualMachines/xyz/providers/Microsoft.Security/assessments/assessmentGuid"
}
"source": "/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/Microsoft.Compute/virtualMachines/xyz/providers/Microsoft.Security/assessments/assessmentGuid",
"action": {
"actionType": "Document",
"link": "https://link3",
"caption": "Enable Soft Delete to protect blob data",
"description": "Enable Soft Delete to protect blob data",
"metadata": {
"id": "/subscriptions/subscriptionId"
}
},
"singular": "Virtual machine",
"plural": "Virtual machines"
},
"actions": [
{
"actionType": "Document",
"link": "https://link1",
"caption": "Enable Soft Delete to protect blob data",
"description": "Enable Soft Delete to protect blob data",
"metadata": {
"id": "/subscriptions/subscriptionId"
}
}
],
"description": "Monitoring agent should be installed on your machines.",
"label": "Enable monitoring agent",
"learnMoreLink": "https://link2",
"potentialBenefits": "Protect and monitor machine"
},
"type": "Microsoft.Advisor/recommendations"
}
Expand Down

0 comments on commit f56f23e

Please sign in to comment.