Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for julia-0.7 #2

Closed
wants to merge 4 commits into from
Closed

Updates for julia-0.7 #2

wants to merge 4 commits into from

Conversation

ederag
Copy link

@ederag ederag commented May 12, 2018

WIP. Updates for julia-0.7 (using Plots still has errors)

currently stuck on

ERROR: LoadError: LoadError: LoadError: Must call userplot on a type/immutable expression.  Got: mutable struct ShowTheme
    #= /home/ederag/.julia/v0.7/RecipesBase/src/RecipesBase.jl:374 =#
    args
end

It seem related to the deprecation of type

Replacing @userplot with

@userplot mutable struct ShowTheme
    args
end

now _userplot in RecipesBase.jl fails with
Must call userplot on a type/immutable expression. Got: mutable struct ShowTheme
Tried to replace
if expr.head != :type with
if ! isstructtype(expr.head)
but then
LoadError: MethodError: no method matching isstructtype(::Symbol)

Updating _userplot is too much for a julia newbie.
Giving up.

Attempt at solving the following
Warning: `isdefined(:symbol)` is deprecated, use `@isdefined symbol` instead
But the warning remains
solves
Warning: `linspace(start, stop, length::Integer)` is deprecated,
         use `range(start, stop=stop, length=length)` instead.
@mkborregaard
Copy link
Owner

Yes, this is definitely very advanced stuff for a julia newbie. You're welcome to make a smaller functional PR to the 0.7 branch on the JuliaPlots fork fork of Plots (this is my personal fork).

@ederag
Copy link
Author

ederag commented Jun 15, 2018

A PR to your fork was intentional, since you already started working on a julia v0.7 branch,
and it was not possible to test it before the advanced stuff is solved.
You could just use that as a starting point, to save some time.
But maybe you mean that femtocleaner will be used and this PR is not necessary any longer ?

@mkborregaard
Copy link
Owner

Femtocleaner will be used, yes.
There's also a 0.7 branch on the JuliaPlots repo. But thanks for the effort, much appreciated.

@ederag
Copy link
Author

ederag commented Jun 16, 2018

Understood.

@ederag ederag deleted the update-0.7 branch June 16, 2018 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants