Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement thead height height larger than original #52

Closed
deep42 opened this issue Feb 16, 2014 · 8 comments
Closed

Replacement thead height height larger than original #52

deep42 opened this issue Feb 16, 2014 · 8 comments
Labels

Comments

@deep42
Copy link

deep42 commented Feb 16, 2014

Don't know if there is a specific problem on my end, but the replacement thead for the original table has a bigger height than it should. In my case thead has 24px, but the actual th, that has no borders, just padding, has 20px.

So, I changed the following variable in setHeaderHeight():
var headerHeight = $header.find('th').outerHeight(true); (instead of $header.outerHeight(true))

In initially thought to keep the bigger height, because it looks better, so I added the following line in the same function:
$floatTable.find('thead > tr').height(headerHeight);

@mkoryak
Copy link
Owner

mkoryak commented Feb 16, 2014

please post an example of this bug to jsfiddle. I need to see the bug in order to fix it.

also, are you using inline styles on the table elements? if so, you should change it to use css selectors and use the table's class in them (add one if needed)

@deep42
Copy link
Author

deep42 commented Feb 16, 2014

No inline styles. See http://jsfiddle.net/V9Fpn/.

It might not be a bug, just something CSS related, but I just wanted to let others know I encountered this scenario and what I did to get around it.

@mkoryak
Copy link
Owner

mkoryak commented Feb 16, 2014

Seems to be a bug. I have a fix for it in the next release which is not officially out but you can see that it works:

http://jsfiddle.net/V9Fpn/1/

Thanks for letting me know about it.

@mkoryak mkoryak added the bug label Feb 16, 2014
@mkoryak
Copy link
Owner

mkoryak commented Feb 16, 2014

this should be fixed in latest version

@mkoryak mkoryak closed this as completed Feb 16, 2014
@deep42
Copy link
Author

deep42 commented Feb 17, 2014

Thank you. All the best.

mkoryak added a commit that referenced this issue Mar 21, 2014
@vinika02
Copy link

vinika02 commented Jul 8, 2019

Please try this. It's worked for me

  var $table = $('table.table-wages');
        $table.floatThead({
            scrollingTop: 0,
            useAbsolutePositioning: false,
            scrollContainer: function($table){
                return $table.closest('.table-wages-container');
            }

        });

// try to resize table thead. tr
$(".size-row,.floatThead-col").css("height", '48px');

@mkoryak
Copy link
Owner

mkoryak commented Jul 8, 2019 via email

@lock
Copy link

lock bot commented Dec 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants