Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MORAE] Add support for functions as arguments into code2amr #622

Closed
Tracked by #632
Free-Quarks opened this issue Nov 7, 2023 · 0 comments · Fixed by #723
Closed
Tracked by #632

[MORAE] Add support for functions as arguments into code2amr #622

Free-Quarks opened this issue Nov 7, 2023 · 0 comments · Fixed by #723
Assignees
@Free-Quarks @vincentraymond-ua
Labels
MORAE
Milestone
[DARPA] Milestone 11

Comments

@Free-Quarks
Copy link
Collaborator

The inclusion of functions as arguments requires support in 2 primary areas:

  1. Adding support in the conversion of the Function Network to Memgraph. This will require some added inference to get the names of the new expressions based on Literals at the top level. Primarily a task for @Free-Quarks
  2. Adding support for getting the names of these expressions into the RHS of the differential equations used in AMR extraction. The dataflow will be a fair bit different in this case and as a result might require some more work to parse correctly into an equation. Primarily a task for @vincentraymond-ua and @Free-Quarks
@Free-Quarks Free-Quarks mentioned this issue Nov 7, 2023
Open
@myedibleenso myedibleenso added this to the [DARPA] Milestone 11 milestone Nov 15, 2023
@Free-Quarks Free-Quarks mentioned this issue Dec 7, 2023
Merged
Free-Quarks added a commit that referenced this issue Dec 7, 2023
@Free-Quarks
Initial Function as Argument support for code2amr (#723)
094b7ec 
## Summary of Changes
This updates the database.rs to support function calls as arguments,
this required adding support for sub-expressions inside expressions.
These sub-expressions are related to the calling of the argument
functions

This also updates model_extraction.rs to add support for handling these
sub-expressions to get the full AMR's out. This includes new trimming to
delete the sub-expressions while connecting the primitives directly to
the argument functions.

### Related issues

Resolves #622

---------

Co-authored-by: Justin <[email protected]>
github-actions bot added a commit that referenced this issue Dec 7, 2023
@github-actions
Initial Function as Argument support for code2amr (#723)
f452029 
## Summary of Changes
This updates the database.rs to support function calls as arguments,
this required adding support for sub-expressions inside expressions.
These sub-expressions are related to the calling of the argument
functions

This also updates model_extraction.rs to add support for handling these
sub-expressions to get the full AMR's out. This includes new trimming to
delete the sub-expressions while connecting the primitives directly to
the argument functions.

### Related issues

Resolves #622

---------

Co-authored-by: Justin <[email protected]> 094b7ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Free-Quarks Free-Quarks

@vincentraymond-ua vincentraymond-ua

Labels
MORAE
Projects
None yet
Milestone
[DARPA] Milestone 11
Development

Successfully merging a pull request may close this issue.

Initial Function as Argument support for code2amr ml4ai/skema
3 participants
@myedibleenso @Free-Quarks @vincentraymond-ua