Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAST handling of MATLAB matrix literal #636

Closed
jastier opened this issue Nov 8, 2023 · 1 comment
Closed

CAST handling of MATLAB matrix literal #636

jastier opened this issue Nov 8, 2023 · 1 comment
Assignees
Labels

Comments

@jastier
Copy link
Contributor

jastier commented Nov 8, 2023

Add CAST coverage for the MATLAB matrix literals:

x = [1  2  3]

Note that MATLAB does not place commas between matrix values.

@jastier jastier self-assigned this Nov 8, 2023
@jastier jastier added the Code2FN label Nov 8, 2023
@jastier jastier added this to the [DARPA] Milestone 11 milestone Nov 8, 2023
@jastier jastier changed the title Support Tree-sitter parsing of MATLAB matrix literal CAST handling of MATLAB matrix literal Nov 12, 2023
@jastier
Copy link
Contributor Author

jastier commented Nov 14, 2023

Resolved by PR #641

Closed

@jastier jastier closed this as completed Nov 14, 2023
jastier added a commit that referenced this issue Nov 14, 2023
## MATLAB function call, operator and matrix support, code cleanup
This PR adds support for Operators, matrix literals, and function calls.
I also got rid of some old Fortran routines that didn't work with
MATLAB. Added support for some Operator types, we now support four of
them and have three remaining. Those are going to have to be resolved by
translating them to CAST loop constructs.

## Relevant features:
- Added Operator support (Boolean, comparison, unary)
- Added function call node support
- Added n-dimensional matrix support for all primitive types
- Added new CI test cases for all of the above
- Added a file with Waterloo model Tree-sitter syntax tokens

## Bugfixes
- Fixed a bug where CAST output was getting wrapped in an extra list.
- Fixed a bug were the source_refs node wasn't getting included on
certain structures. Our CI now checks them all.

## Related issues
Resolves #590 #635 #636
Work towards #562

---------

Co-authored-by: Joseph Astier <[email protected]>
Co-authored-by: Gus Hahn-Powell <[email protected]>
github-actions bot added a commit that referenced this issue Nov 14, 2023
## MATLAB function call, operator and matrix support, code cleanup
This PR adds support for Operators, matrix literals, and function calls.
I also got rid of some old Fortran routines that didn't work with
MATLAB. Added support for some Operator types, we now support four of
them and have three remaining. Those are going to have to be resolved by
translating them to CAST loop constructs.

## Relevant features:
- Added Operator support (Boolean, comparison, unary)
- Added function call node support
- Added n-dimensional matrix support for all primitive types
- Added new CI test cases for all of the above
- Added a file with Waterloo model Tree-sitter syntax tokens

## Bugfixes
- Fixed a bug where CAST output was getting wrapped in an extra list.
- Fixed a bug were the source_refs node wasn't getting included on
certain structures. Our CI now checks them all.

## Related issues
Resolves #590 #635 #636
Work towards #562

---------

Co-authored-by: Joseph Astier <[email protected]>
Co-authored-by: Gus Hahn-Powell <[email protected]> d193a52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant