Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gromet] Resolve Tuple Return issue #703

Closed
Tracked by #698
vincentraymond-ua opened this issue Nov 29, 2023 · 1 comment · Fixed by #722
Closed
Tracked by #698

[gromet] Resolve Tuple Return issue #703

vincentraymond-ua opened this issue Nov 29, 2023 · 1 comment · Fixed by #722
Labels
bug Something isn't working Code2FN

Comments

@vincentraymond-ua
Copy link
Contributor

vincentraymond-ua commented Nov 29, 2023

There is a bug in the pack_tuple_return function in to_gromet_pass.py.

The error is occurring because of am empty pof somewhere:

last_pof = len(gromet_fn.pof)
TypeError: object of type 'NoneType' has no len()
@vincentraymond-ua vincentraymond-ua changed the title Resolve Tuple Return issue [gromet] Resolve Tuple Return issue Nov 29, 2023
@vincentraymond-ua vincentraymond-ua added bug Something isn't working Code2FN labels Nov 29, 2023
@vincentraymond-ua
Copy link
Contributor Author

I think this could be related to the ModelReturn CAST formatting. Previously, I had the ModelReturn output as a LiteralValue Tuple of Var Nodes, when it should have been Name nodes. Doing some further testing to confirm.

github-actions bot added a commit that referenced this issue Dec 13, 2023
## Summary of Changes
### Fortran->CAST efficiency updates
- Using itertools.accumulate to generate overlapping sums in NodeHelper
class
- Creating a single dummy source reference node instead of creating a
new instance every time we come across a missing source reference.

### CAST->Gromet efficiency updates
- Updates the port_id generation logic

### Fortran->CAST
- Adds `get_children_except_types` function to node_helper.py, which is
the inverse of `get_children_by_types` function.
- Adds `generate_cast_body` function to TS2CAST which handles the
pattern of visiting every node in a List.
- Adds support for unary operators in expressions (a = +b)
- Adds basic support for print statements
- Adds support for function derived type member expressions (b =
a%function())
- Refactors the visitor for the if conditional to increase accuracy and
reduce code
- Refactors return logic to properly differentiate subroutine and
function
### Related issues

Resolves #724  Resolves #721 Resolves #703 cfdf54f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Code2FN
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant