Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code2FN] PhotoMod Variable Version Pass Key Error #839

Closed
titomeister opened this issue Mar 5, 2024 · 2 comments · Fixed by #860
Closed

[code2FN] PhotoMod Variable Version Pass Key Error #839

titomeister opened this issue Mar 5, 2024 · 2 comments · Fixed by #860
Assignees
@titomeister
Labels
bug Something isn't working Code2FN
Milestone
[DARPA] Milestone 12

Comments

@titomeister
Copy link
Contributor

A file from the Hackathon unearthed a strange issue in the variable version pass. It is some kind of KeyError when accessing a dictionary. It appears that a variable ID is missing when it should be.
The example can be reproduced using this small Fortran file
@titomeister titomeister added this to the [DARPA] Milestone 12 milestone Mar 5, 2024
@titomeister titomeister self-assigned this Mar 5, 2024
@titomeister
Copy link
Contributor Author

It appears that when attempting to populate an interface in the Variable version pass using globals, if a global isn't used in the function that we're in then it breaks.

@titomeister titomeister added bug Something isn't working Proposed This is a label for proposed future issues to be addressed beyond ASKEM phase 1 and removed Proposed This is a label for proposed future issues to be addressed beyond ASKEM phase 1 labels Mar 5, 2024
@titomeister
Copy link
Contributor Author

After some more investigation we discovered that the CAST produced by fortran2cast.py had a discrepancy where an extra Name node was appearing at the end of the CAST. We believe this is the root cause for the error in VariableVersionPass.py. Vincent's working on a fix on the Fortran to CAST generation end.

@vincentraymond-ua vincentraymond-ua mentioned this issue Mar 29, 2024
Merged
github-actions bot added a commit that referenced this issue Mar 29, 2024
@github-actions
[m12] code2fn documentation and unit test updates (#860)
8216891 
## Summary of Changes
### Documentation Updates
Updates the endpoint documentation for the following Code2fn services
- code2fn
- execution_engine
- comment_extractor
- workflows

Additionally, adds a new page to the Github site documenting how to add
support for dependency generation for new languages.

### Unit Tests
Adds unit tests for Fortran->CAST to reach parity with Python unit
tests.

### Bug fixes
Fixes bug where extra Name node could be generated at the end of
function definitions
Fixes bug in Loop generation where the wrong loop type could be ingested

### Related issues
#849
#858
#839

Resolves #858
Resolves #839 275bd97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@titomeister titomeister

Labels
bug Something isn't working Code2FN
Projects
None yet
Milestone
[DARPA] Milestone 12
Development

Successfully merging a pull request may close this issue.

[m12] code2fn documentation and unit test updates ml4ai/skema
1 participant
@titomeister