[fortran] Bug fixes for ingestion TIE-GCM source #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/ml4ai/skema into vraymond/execution_engine_testing
github-actions
bot
added
the
lang/Fortran
vincentraymond-ua
changed the title
jastier
approved these changes
Oct 13, 2023
github-actions bot
added a commit
that referenced
this pull request
Oct 14, 2023
## TIE-GCM bug fixes There were a number of small bugs in the Fortran->Gromet pipeline that were discovered when determining which TIE-GCM files are currently able to be ingested. ### Node Helper - Fixes missing comma in CONTROL_CHARACTERS list causing '>' to be ignored. - Adds additional set of control characters to CONTROL_CHARACTERS list that weren't previously seen in any examples - Adds remove_comments function to remove comment nodes from tree-sitter parse tree. This prevents comments from being processed by ts2cast and creating unexpected None values in the CAST. ### Preprocessor - Fixes bug in include directory path when running script from directory other than the system root. - Runs gcc processor from system root if there are no `#include` directives. ### TS2CAST - Fixes bug in function call handler to support ingesting functions with no arguments. - Fixes bug when in function call handler when the function call is part of a unary expression `+foo()` - Fixes bug in conditional handler to support ingesting single line conditionals - Adds support for `not` operator Resolves #563 7ae4f25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIE-GCM bug fixes
There were a number of small bugs in the Fortran->Gromet pipeline that were discovered when determining which TIE-GCM files are currently able to be ingested.
Node Helper
Preprocessor
#includedirectives.TS2CAST
+foo()notoperatorResolves #563