Waterloo Model CAST translation #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
November 17, 2023 17:34
…astier/function_defs
github-actions
bot
added
the
lang/MATLAB
…astier/function_defs
…astier/function_defs
vincentraymond-ua
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
@jastier - This looks good Joseph! I like all of the tests that you've added for different operations.
github-actions bot
added a commit
that referenced
this pull request
Nov 20, 2023
## Summary of Changes This PR extends our coverage of MATLAB to include functions and commands. Add some more test cases to reinforce existing test classes. The Waterloo Model will now fully translate without 'None' values in the output ## Relevant Features - Added function and command processing - Added support for parenthesized nodes - Added support for all operator types at least to a first order. - Added PEMDAS checking for sequential arithmetic operators ## Bugfixes - Fixed a bug where there could be 'None' values in the CAST output ### Related issues Resolves #562 #647 partially #671 --------- Co-authored-by: Joseph Astier <[email protected]> 03cced3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR extends our coverage of MATLAB to include functions and commands. Add some more test cases to reinforce existing test classes. The Waterloo Model will now fully translate without 'None' values in the output
Relevant Features
Bugfixes
Related issues
Resolves #562 #647
partially #671