Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waterloo Model CAST translation #671

Merged
merged 45 commits into from
Nov 20, 2023
Merged

Waterloo Model CAST translation #671

merged 45 commits into from
Nov 20, 2023

Conversation

jastier
Copy link
Contributor

@jastier jastier commented Nov 19, 2023

Summary of Changes

This PR extends our coverage of MATLAB to include functions and commands. Add some more test cases to reinforce existing test classes. The Waterloo Model will now fully translate without 'None' values in the output

Relevant Features

  • Added function and command processing
  • Added support for parenthesized nodes
  • Added support for all operator types at least to a first order.
  • Added PEMDAS checking for sequential arithmetic operators

Bugfixes

  • Fixed a bug where there could be 'None' values in the CAST output

Related issues

Resolves #562 #647
partially #671

@jastier jastier marked this pull request as draft November 19, 2023 05:54
@github-actions github-actions bot added the lang/MATLAB Used for work related to MATLAB frontend label Nov 19, 2023
@jastier jastier self-assigned this Nov 19, 2023
@jastier jastier added this to the [DARPA] Milestone 11 milestone Nov 19, 2023
@jastier jastier marked this pull request as ready for review November 19, 2023 07:19
Copy link
Contributor

@vincentraymond-ua vincentraymond-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jastier - This looks good Joseph! I like all of the tests that you've added for different operations.

@jastier jastier merged commit 03cced3 into main Nov 20, 2023
8 checks passed
@jastier jastier deleted the jastier/function_defs branch November 20, 2023 22:57
github-actions bot added a commit that referenced this pull request Nov 20, 2023
## Summary of Changes
This PR extends our coverage of MATLAB to include functions and
commands. Add some more test cases to reinforce existing test classes.
The Waterloo Model will now fully translate without 'None' values in the
output

##  Relevant Features
- Added function and command processing
- Added support for parenthesized nodes
- Added support for all operator types at least to a first order.
- Added PEMDAS checking for sequential arithmetic operators

## Bugfixes
- Fixed a bug where there could be 'None' values in the CAST output

### Related issues
Resolves #562 #647
partially #671

---------

Co-authored-by: Joseph Astier <[email protected]> 03cced3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/MATLAB Used for work related to MATLAB frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAST translation of MATLAB functions
2 participants