[fortran] Fix for function declarations in derived types #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into vraymond/photo_mod_fix
github-actions
bot
added
the
lang/Fortran
vincentraymond-ua
changed the title
titomeister
approved these changes
Mar 4, 2024
|
@titomeister - I've updated the branch to remove the unneeded todos. Some were resolved by this fix and others are just left over things from previously. |
github-actions bot
added a commit
that referenced
this pull request
Mar 4, 2024
## Summary of Changes There was a bug discovered in the CTSM source PhotosynthesisMod.F90 where a function is declared in a derived type but defined in the outer module. This PR updates the variable context to support this case. Additionally resolves a bug where function declarations and definitions can have different case sensitivity. ### Related issues Resolves ??? --------- Co-authored-by: titomeister <[email protected]> 156e193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
There was a bug discovered in the CTSM source PhotosynthesisMod.F90 where a function is declared in a derived type but defined in the outer module. This PR updates the variable context to support this case.
Additionally resolves a bug where function declarations and definitions can have different case sensitivity.
Related issues
Resolves ???