Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data] Refactors skema to fetch artifacts locally instead of from artifacts.askem.lum.ai #881

Merged
merged 16 commits into from
Apr 23, 2024
Merged

[data] Refactors skema to fetch artifacts locally instead of from artifacts.askem.lum.ai #881

merged 16 commits into from
Apr 23, 2024

Conversation

vincentraymond-ua
Copy link
Contributor

@vincentraymond-ua vincentraymond-ua commented Apr 19, 2024 •
edited
Loading

Summary of Changes

Refactors skema codebase to fetch data artifacts locally instead of from artifacts.askem.lum.ai.

Changes

  • skema.data submodule created to store local artifacts
  • model zip archives now stored locally under skema/data
  • img2mml model is stored in a huggingface repository and is downloaded at runtime.
  • huggingface_hub added as a dependency
  • deploy.yml workflow removed
  • Old .drone.yml CI file removed
  • Updated documentation to account for these changes

@vincentraymond-ua vincentraymond-ua marked this pull request as ready for review April 22, 2024 13:40
@github-actions github-actions bot added the CI continuous integration and automated workflows label Apr 22, 2024
@vincentraymond-ua vincentraymond-ua marked this pull request as draft April 22, 2024 13:42
@vincentraymond-ua vincentraymond-ua changed the title Vraymond/artifact updates [data] Refactors skema to fetch artifacts locally instead of from artifacts.askem.lum.ai Apr 23, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 23, 2024
@vincentraymond-ua vincentraymond-ua marked this pull request as ready for review April 23, 2024 16:28
myedibleenso
myedibleenso approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@myedibleenso myedibleenso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vincentraymond-ua !

@myedibleenso myedibleenso merged commit 6cda598 into main Apr 23, 2024
7 checks passed
@myedibleenso myedibleenso deleted the vraymond/artifact_updates branch April 23, 2024 19:03
@vincentraymond-ua vincentraymond-ua restored the vraymond/artifact_updates branch April 24, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myedibleenso myedibleenso myedibleenso approved these changes

Assignees
No one assigned
Labels
CI continuous integration and automated workflows documentation Improvements or additions to documentation Equations Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentraymond-ua @myedibleenso