Make Fondant installable via git #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrchtr
reviewed
Feb 7, 2024
|
Yes, since I didn't want to move the components that you are deleting. We can wait with merging until after that one is merged. |
mrchtr
approved these changes
Feb 8, 2024
Base automatically changed from
feature/remove-reusable-RAG-components
to
main
February 9, 2024 13:30
RobbeSneyders
added a commit
that referenced
this pull request
Feb 12, 2024
This PR updates the components path which was changed in #849.
RobbeSneyders
added a commit
that referenced
this pull request
Feb 20, 2024
The new packaging strategy introduced in #849 doesn't work correctly for wheels due to a bug in poetry (python-poetry/poetry#8994), which breaks installing both from Github and PyPi. This PR introduces a workaround. Since the bug is related to the `src` directory, this workaround adds a `pre-build/sh` script which unpacks the `src` directory before building, and a `post-build.sh` script which moves the package back into the `src` directory afterwards. This leads to the following result: - Installing from Github leads to an installation including all component files - Installing locally without running the build script leads to an installation including all component files - Installing from PyPi leads to an installation with only the `fondant_component.yaml` files for each component In the ideal case, we get the same result for all installation methods, but this already at least leads to a working result for each method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves our components into the source folder so Fondant becomes installable via git.
The reason to have them at the top level before was because we didn't have a hub. Now that we have the hub page on the fondant.ai site, I think the trade-off has shifted.
I will update the references in the use case repositories as well.