Handle RPC_E_CHANGED_MODE return value from CoInitializeEx better. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
|
Please just go ahead and merge this, it's safe and more people are running into the bug, see the new comment in #72 . |
|
Similar implementation has been added on top of a refactor so this PR will not be directly accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72.
This is my proposal for a minimal-impact fix for the issue. I don't know if anyone really still uses COINIT_APARTMENTTHREADED mode though.
When CoInitializeEx returns RPC_E_CHANGED_MODE, it's not because it actually changed the mode but because you requested an invalid mode change, which didn't actually happen. COM still works in the old mode. So handling this error and avoiding calling CoUninitialize fixes this with zero impact to existing code.