Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving node time duration resolution #58

Open
Tobi-Alonso opened this issue May 13, 2024 · 1 comment
Open

Improving node time duration resolution #58

Tobi-Alonso opened this issue May 13, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Tobi-Alonso
Copy link

Problem Related to the Feature

As defined in the et_def.proto, the attribute that stores duration (duration_micros) uses microsecond precision.
There are some cases where we encounter lots of sub-microsecond-runtime COMP_NODE nodes, which cannot be aggregated into larger compute COMP_NODE. These times can add up, and turn into a significant amount of time.

Proposed Solution

I think it makes sense to have nanoseconds precision. Probably a double type would be the way to go. The simulator can then cap to the precision it's the best for its use cases.
The above seems to be the more straightforward solution, but alternatively, a per-node or per-trace "timescale" field could also do the trick.

@srinivas212
Copy link
Contributor

Thanks for reporting this issue. We will consider this in the next revision of schema.

One issue with adopting nanosecond would be to convert the default of every op we collect, incl. from other tools like Kineto. But double seems like a viable solution.

@srinivas212 srinivas212 added enhancement New feature or request help wanted Extra attention is needed labels May 18, 2024
rvinaybharadwaj pushed a commit to rvinaybharadwaj/chakra that referenced this issue Sep 23, 2024
Enable Chakra to convert PyTorch ET augmented Kineto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants