Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Copy bbq_metric into NewHELM, roughly split to where it should go. #34

Merged
merged 18 commits into from
Jan 11, 2024
Merged

Copy bbq_metric into NewHELM, roughly split to where it should go. #34

merged 18 commits into from
Jan 11, 2024

Conversation

brianwgoldman
Copy link
Contributor

No description provided.

@brianwgoldman
Create a utility module for multiple choice questions.
f98e54d 
In HELM this is the most common type of prompt. It is also how BBQ works, so I'll need it in fleshing out that Test.
@brianwgoldman
Forgot to remove newline
98e1254
@brianwgoldman
Copy over BBQ scenario to prepare for integration.
059a4ba
@brianwgoldman
Somehow forgot the actual bbq file.
45a0424
@brianwgoldman
Most of the way to making TestItems.
b653b61
@brianwgoldman
Update formatting to match what HELM uses.
48ed4a7
@brianwgoldman
Remove unused import
a87417e
@brianwgoldman
Copy bbq_metric into NewHELM, roughly split to where it should go.
6cda68b
@brianwgoldman
Use a dataclass to hold context.
1193712
@brianwgoldman
Merge branch 'auxy/bbq-make-instances' into auxy/copy-bbq-metric
c68933b
@brianwgoldman
Fix some typing mistakes
28eced5
@brianwgoldman
Merge branch 'auxy/bbq-make-instances' into auxy/copy-bbq-metric
9d7e44a
@brianwgoldman
Merge branch 'main' into auxy/multiple-choice
44c5d90
@brianwgoldman
Merge branch 'auxy/multiple-choice' into auxy/copy-bbq-scenario
3d3ccd8
@brianwgoldman
Merge branch 'auxy/copy-bbq-scenario' into auxy/bbq-make-instances
2414dbc
@brianwgoldman
Merge branch 'auxy/bbq-make-instances' into auxy/copy-bbq-metric
37339a9
@brianwgoldman brianwgoldman requested a review from a team as a code owner January 9, 2024 16:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

yifanmai
yifanmai approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@yifanmai yifanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is an intermediate PR, since it doesn't seem to actually work?

@brianwgoldman
Copy link
Contributor Author

I assume this is an intermediate PR, since it doesn't seem to actually work?

Correct. PR #35 makes it work.

@brianwgoldman brianwgoldman changed the base branch from auxy/bbq-make-instances to main January 11, 2024 17:08
@brianwgoldman brianwgoldman merged commit 49b9270 into main Jan 11, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
@brianwgoldman brianwgoldman deleted the auxy/copy-bbq-metric branch January 12, 2024 20:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yifanmai yifanmai yifanmai approved these changes

@bollacker bollacker Awaiting requested review from bollacker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianwgoldman @yifanmai