This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
HuggingFace Inference SUT #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
wpietri
approved these changes
Sep 11, 2024
|
@wpietri Like what specifically? The code all seems specific to huggingface to me. |
rogthefrog
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
👍🏻
A few thoughts about how to address the together/huggingface/other client management in this comment.
That's exactly my concern. There's a lot about Hugging Face that's not particularly about a SUT. Since we have annotators that also deal with HuggingFace, there's duplication to be extracted. I also think the stuff about waiting to spin up a model is very much not about SUT-ness, and more about operational concerns. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.