Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify rules regarding the review committee #180

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ShriyaPalsamudram
Copy link
Contributor

The current rules are not clear about review chair selection process and the review committee composition. So this PR aims to clarify those reviews.

@ShriyaPalsamudram ShriyaPalsamudram requested a review from a team as a code owner July 11, 2024 14:16
Copy link

github-actions bot commented Jul 11, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@TheKanter
Copy link
Contributor

Hi Shriya - I think it's good to clarify the rules here, but a few comments:

  1. We need to change the review committee to reference the head of MLPerf and probably rethink composition a bit
  2. I'd like to work with other impacted WGs to discuss (and possibly figure out a good system that gives folks a voice, but doesn't prevent changes)
  3. I haven't read it in any further detail, so more to come :)

@ShriyaPalsamudram
Copy link
Contributor Author

ShriyaPalsamudram commented Jul 11, 2024 via email

@nv-ananjappa
Copy link

@mrmhodak @mrasquinha-g Can we review this rules change for v4.1 submission in next Tue WGM?

@arjunsuresh
Copy link
Contributor

Can we add MLCommons staff to the review meeting? We do have a requirement to attend the review meeting for reproducibility purposes.

Copy link

@psyhtest psyhtest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relevant working group chair or power working group chair may be a valid candidate as well if approved by unanimous consent.

Unanimous consent for approval sounds too strict. A simple majority should suffice, IMHO.

@mrasquinha-g
Copy link
Contributor

Can we please add this to the next benchmark chairs working group meeting agenda for discussion.

@swasson488
Copy link

swasson488 commented Jul 16, 2024 via email

@rnchukka
Copy link

@ShriyaPalsamudram Do you have any context to the rules change proposal? In specific to the part where wg or power wg chairs participation/omission was mentioned. Since Monthly WG chair meeting is planning to discuss this item, should we wait for the opinion from that meeting before the changes are codified. To limit the results exposure for v4.1 Inference submission, Results committee can decide on some solution to let WG chairs participation on a need to know basis or let one WG co-chair join the meetings.

@ShriyaPalsamudram ShriyaPalsamudram marked this pull request as draft July 19, 2024 21:07
@ShriyaPalsamudram
Copy link
Contributor Author

ShriyaPalsamudram commented Jul 19, 2024

Given that discussion on this is pending, I marked it as a draft. Let's talk about it further in the Chairs WG meeting.

For now, we can keep everything as is, especially for v4.1 Inference submission.

@arjunsuresh
Copy link
Contributor

Hi @ShriyaPalsamudram , please consider the below requests too

  1. Should we limit the number of representatives from an organization attending the review meetings? Also, if some company is outsourcing their submission work to a new company (say to a non-MLC member company) - can those representatives attend the review meeting on behalf of the submitter company? My proposal would be upto 2 representatives from each submitter - they can be an employee or a representative.
  2. We need to clarify who among the MLC staff can attend the review meetings - even the current rule doesn't clarify this but MLC staffs are managing the submission repositories. May be "upto 2 MLC staffs as agreed by the respective WG".

Copy link
Contributor

@TheKanter TheKanter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From an MLC standpoint, we see some challenges with Line 42 and wish to ensure WG chairs are included in the review committee. However, we understand the concerns that this potentially enables non-submitters into the confidentiality of the results review process. We share the goal of encouraging submission and want to avoid mechanisms to arbitrage access to the results. Instead suggest that we make it an explicit requirement that any all review committee members respect confidentiality and keep all results confidential even from their employer.

Further comments:

  1. MLC needs WG chairs to see results to help analyze for marketing and drive better results briefing, press coverage, commentary, etc. MLC staff alone may lack the detailed knowledge and background to fully understand on their own. This is critical to driving benefits for all submitters.
  2. From a marketing standpoint, we often quote WG chairs which is difficult unless they can see the results.
  3. WG chair is an elected position and therefore a position of trust. Allowing any submitter to unilaterally over-rule that election seems bad form and contradictory.
  4. MLC has a culture of trust and collaboration that has worked in the past and helps us to move quickly which is necessary for working with ML generally. WG chair is a significant investment of time and we should honor that investment and presume good faith - especially as they empowered to act on behalf of MLC. Culturally, we should only depart from this norm where abuse is an issue.
  5. Observing and participating in the review process often directly informs subsequent rules changes and is valuable for this reason.
  6. MLC cannot always find independent review chairs which makes WG chairs more helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants