Clean up devcontainer.json
#10187
Merged
Clean up devcontainer.json
#10187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for f34f847 will be available here when this CircleCI job completes successfully. More info
|
harupy
commented
Oct 27, 2023
Comment on lines
+9
to
+11
| "customizations": { | ||
| "vscode": { | ||
| "settings": { |
There was a problem hiding this comment.
Used customizations/vscode/settings as vscode recommends:
harupy
commented
Oct 27, 2023
Comment on lines
-14
to
-15
| // Disable automatic environment activation because `.zshrc` contains `conda activate mlflow-dev-env`. | ||
| "python.terminal.activateEnvironment": false, |
There was a problem hiding this comment.
We no longer use conda in devcontainer.
harupy
commented
Oct 27, 2023
Comment on lines
-17
to
-18
| "python.linting.enabled": false, | ||
| "python.formatting.provider": "black", |
There was a problem hiding this comment.
These two settings are deprecated. Removed.
harupy
force-pushed
the
clean-up-devcontainer.json
branch
from
05c90bb
to
7697489
Compare
Signed-off-by: harupy <[email protected]>
harupy
force-pushed
the
clean-up-devcontainer.json
branch
from
7697489
to
f0a76f9
Compare
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
KonakanchiSwathi
pushed a commit
to KonakanchiSwathi/mlflow
that referenced
this pull request
Nov 29, 2023
Signed-off-by: harupy <[email protected]> Signed-off-by: swathi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 DevTools 🛠
Install mlflow from this PR
Checkout with GitHub CLI
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Made several changes in
devcontainer.jsonto clean it up.How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/gateway: AI Gateway service, Gateway client APIs, third-party Gateway integrationsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes