Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message for missing "targets" column #10723

Merged
merged 11 commits into from
Dec 24, 2023

Conversation

annzhang-db
Copy link
Collaborator

@annzhang-db annzhang-db commented Dec 19, 2023

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

pip install git+https://github.com/mlflow/mlflow.git@refs/pull/10723/merge

Checkout with GitHub CLI

gh pr checkout 10723

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

  • Neither "target" or "targets" is accepted as a column from dataset, since "prediction" and "target" are not normal columns we should not treat them like columns (seems more confusing, since they will behave differently from other columns and we want users to use targets= instead of col_mapping)
  • Instead, clarify the requirements to ask for targets parameter or predictions parameter to be specified

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests
Screenshot 2023-12-20 at 4 46 15 PM

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/deployments: MLflow Deployments client APIs, server, and third-party Deployments integrations
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: Ann Zhang <[email protected]>
Copy link

github-actions bot commented Dec 19, 2023

Documentation preview for 60c32ed will be available here when this CircleCI job completes successfully.

More info

Copy link
Collaborator

@sunishsheth2009 sunishsheth2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test where targets and target are both excepted?

Signed-off-by: Ann Zhang <[email protected]>
Signed-off-by: Ann Zhang <[email protected]>
Signed-off-by: Ann Zhang <[email protected]>
Signed-off-by: Ann Zhang <[email protected]>
Signed-off-by: Ann Zhang <[email protected]>
Signed-off-by: Ann Zhang <[email protected]>
Signed-off-by: Ann Zhang <[email protected]>
@annzhang-db annzhang-db changed the title Accept "targets" column Fix error message for missing "targets" column Dec 20, 2023
@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Dec 20, 2023
Signed-off-by: Ann Zhang <[email protected]>
Signed-off-by: Ann Zhang <[email protected]>
Signed-off-by: Ann Zhang <[email protected]>
Copy link
Collaborator

@prithvikannan prithvikannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annzhang-db annzhang-db merged commit e2de758 into mlflow:master Dec 24, 2023
38 checks passed
@annzhang-db annzhang-db deleted the targets branch December 24, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants