-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free some disk space in python job #9153
Merged
harupy
merged 2 commits into
mlflow:master
from
harupy:debug-test_mlflow_artifacts_example
Jul 25, 2023
Merged
Free some disk space in python job #9153
harupy
merged 2 commits into
mlflow:master
from
harupy:debug-test_mlflow_artifacts_example
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harupy
commented
Jul 25, 2023
Signed-off-by: harupy <[email protected]>
harupy
force-pushed
the
debug-test_mlflow_artifacts_example
branch
from
July 25, 2023 00:56
56ce413
to
6ca7b91
Compare
Signed-off-by: harupy <[email protected]>
Documentation preview for b725c7c will be available here when this CircleCI job completes successfully. More info
|
harupy
changed the title
Debug test mlflow artifacts example
Free some disk space in python job
Jul 25, 2023
harupy
commented
Jul 25, 2023
Comment on lines
+244
to
+250
err=0 | ||
trap 'err=1' ERR | ||
./build.sh | ||
docker-compose run -v ${{PWD}}/example.py:/app/example.py client python example.py | ||
docker-compose logs | ||
docker-compose down {rmi_option} --volumes --remove-orphans | ||
test $err = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to always run docker-compose logs
dbczumar
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
BenWilson2
pushed a commit
to BenWilson2/mlflow
that referenced
this pull request
Jul 31, 2023
Signed-off-by: harupy <[email protected]>
clarkh-ncino
pushed a commit
to ncino/mlflow
that referenced
this pull request
Aug 23, 2023
Signed-off-by: harupy <[email protected]> Signed-off-by: Clark Hollar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Fix the following error in
tests/tracking/test_mlflow_artifacts.py::test_mlflow_artifacts_example
:https://github.com/mlflow/mlflow/actions/runs/5651381939/job/15309401913?pr=9153#step:10:3534
How is this patch tested?
Does this PR change the documentation?
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/gateway
: AI Gateway service, Gateway client APIs, third-party Gateway integrationsarea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes