Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free some disk space in python job #9153

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

harupy
Copy link
Member

@harupy harupy commented Jul 24, 2023

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Fix the following error in tests/tracking/test_mlflow_artifacts.py::test_mlflow_artifacts_example:

https://github.com/mlflow/mlflow/actions/runs/5651381939/job/15309401913?pr=9153#step:10:3534

artifacts-server_1     | 2023/07/25 01:40:13 ERROR mlflow.server: Exception on /api/2.0/mlflow-artifacts/artifacts/experiments/0/0c10998073be4e8b936d401bad8abf6b/artifacts/a.txt [PUT]
artifacts-server_1     | Traceback (most recent call last):
artifacts-server_1     |   File "/usr/local/lib/python3.8/site-packages/boto3/s3/transfer.py", line 292, in upload_file
artifacts-server_1     |     future.result()
artifacts-server_1     |   File "/usr/local/lib/python3.8/site-packages/s3transfer/futures.py", line 103, in result
artifacts-server_1     |     return self._coordinator.result()
artifacts-server_1     |   File "/usr/local/lib/python3.8/site-packages/s3transfer/futures.py", line 266, in result
artifacts-server_1     |     raise self._exception
artifacts-server_1     |   File "/usr/local/lib/python3.8/site-packages/s3transfer/tasks.py", line 139, in __call__
artifacts-server_1     |     return self._execute_main(kwargs)
artifacts-server_1     |   File "/usr/local/lib/python3.8/site-packages/s3transfer/tasks.py", line 162, in _execute_main
artifacts-server_1     |     return_value = self._main(**kwargs)
artifacts-server_1     |   File "/usr/local/lib/python3.8/site-packages/s3transfer/upload.py", line 758, in _main
artifacts-server_1     |     client.put_object(Bucket=bucket, Key=key, Body=body, **extra_args)
artifacts-server_1     |   File "/usr/local/lib/python3.8/site-packages/botocore/client.py", line 534, in _api_call
artifacts-server_1     |     return self._make_api_call(operation_name, kwargs)
artifacts-server_1     |   File "/usr/local/lib/python3.8/site-packages/botocore/client.py", line 976, in _make_api_call
artifacts-server_1     |     raise error_class(parsed_response, operation_name)
artifacts-server_1     | botocore.exceptions.ClientError: An error occurred (XMinioStorageFull) when calling the PutObject operation: Storage backend has reached its minimum free drive threshold. Please delete a few objects to proceed.

How is this patch tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests (describe details, including test results, below)

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly in the documentation preview.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/gateway: AI Gateway service, Gateway client APIs, third-party Gateway integrations
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

.github/workflows/master.yml Outdated Show resolved Hide resolved
@harupy harupy force-pushed the debug-test_mlflow_artifacts_example branch from 56ce413 to 6ca7b91 Compare July 25, 2023 00:56
@harupy harupy marked this pull request as ready for review July 25, 2023 01:58
Signed-off-by: harupy <[email protected]>
@mlflow-automation
Copy link
Collaborator

Documentation preview for b725c7c will be available here when this CircleCI job completes successfully.

More info

@harupy harupy added the rn/none List under Small Changes in Changelogs. label Jul 25, 2023
@harupy harupy changed the title Debug test mlflow artifacts example Free some disk space in python job Jul 25, 2023
@harupy harupy requested a review from kriscon-db July 25, 2023 02:16
Comment on lines +244 to +250
err=0
trap 'err=1' ERR
./build.sh
docker-compose run -v ${{PWD}}/example.py:/app/example.py client python example.py
docker-compose logs
docker-compose down {rmi_option} --volumes --remove-orphans
test $err = 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to always run docker-compose logs

@harupy harupy enabled auto-merge (squash) July 25, 2023 03:03
Copy link
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harupy harupy merged commit 64d4a51 into mlflow:master Jul 25, 2023
28 of 29 checks passed
@harupy harupy deleted the debug-test_mlflow_artifacts_example branch July 25, 2023 03:35
@harupy harupy mentioned this pull request Jul 26, 2023
34 tasks
BenWilson2 pushed a commit to BenWilson2/mlflow that referenced this pull request Jul 31, 2023
clarkh-ncino pushed a commit to ncino/mlflow that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants