Sort import statements (excluding mlflow for now)
#9409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: harupy <[email protected]>
harupy
added
the
only-latest
|
Documentation preview for c969075 will be available here when this CircleCI job completes successfully. More info
|
harupy
commented
Aug 22, 2023
Comment on lines
+76
to
+80
| "mlflow/*" = [ | ||
| "PT018", | ||
| # TODO: Sort imports in files under `mlflow` as well | ||
| "I", | ||
| ] |
There was a problem hiding this comment.
Disabled for now because changing the import order may lead to circular imports.
harupy
requested review from
a team,
WeichenXu123,
gabrielfu,
BenWilson2,
dbczumar and
serena-ruan
BenWilson2
approved these changes
Aug 22, 2023
|
@chenmoneygithub Thoughts on this? |
harupy
commented
Aug 22, 2023
| @@ -18,6 +18,7 @@ select = [ | |||
| "E", | |||
| "F", | |||
| "C4", | |||
| "I", | |||
There was a problem hiding this comment.
If this is too strict and we want to disable import sorting, we can remove this line.
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
This was referenced Aug 23, 2023
Merged
clarkh-ncino
pushed a commit
to ncino/mlflow
that referenced
this pull request
Aug 23, 2023
Signed-off-by: harupy <[email protected]> Signed-off-by: Clark Hollar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Sort import statements (excluding
mlflowfor now) to ban unnecessary changes on import statements.I've made a comment like "Hey, can you revert unnecessary changes on import statements" countless times, which is a pain. Once this PR is merged, I will no longer have to.
How is this patch tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/gateway: AI Gateway service, Gateway client APIs, third-party Gateway integrationsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes