-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix torch cross test on torch < 1.8 #9420
Fix torch cross test on torch < 1.8 #9420
Conversation
Signed-off-by: Weichen Xu <[email protected]>
@WeichenXu123 Looks like https://github.com/pytorch/pytorch/blob/main/torch/utils/_pytree.py |
But in torch 1.6 / 1.7 the module disappears. you can install it and test. |
@WeichenXu123 Why did it disappear? |
I checked again, I think 1.6/1.7 package is not changed and |
@WeichenXu123 Got it, then we can pin transformers. |
ok. |
This reverts commit ebeb771.
Signed-off-by: Weichen Xu <[email protected]>
Documentation preview for 3982a41 will be available here when this CircleCI job completes successfully. More info
|
Signed-off-by: Weichen Xu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once https://github.com/mlflow/mlflow/pull/9420/files#r1302458403 is resolved.
Signed-off-by: Weichen Xu <[email protected]>
Signed-off-by: Weichen Xu <[email protected]> Signed-off-by: Clark Hollar <[email protected]>
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Broken test:
https://github.com/mlflow-automation/mlflow/actions/runs/5939342578/job/16106694740#step:13:220
For torch 1.6 / 1.7, the module
torch.utils._pytree
does not exist , then it is incompatible with latest transformers bert model,we can verify this by
then run
How is this patch tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/gateway
: AI Gateway service, Gateway client APIs, third-party Gateway integrationsarea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes