Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix torch cross test on torch < 1.8 #9420

Merged

Conversation

WeichenXu123
Copy link
Collaborator

@WeichenXu123 WeichenXu123 commented Aug 23, 2023

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Broken test:
https://github.com/mlflow-automation/mlflow/actions/runs/5939342578/job/16106694740#step:13:220

For torch 1.6 / 1.7, the module torch.utils._pytree does not exist , then it is incompatible with latest transformers bert model,
we can verify this by

PIP_EXTRA_INDEX_URL=https://download.pytorch.org/whl/cpu pip install torch==1.7

then run

>>> import torch.utils._pytree
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'torch.utils._pytree'

How is this patch tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests (describe details, including test results, below)

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/gateway: AI Gateway service, Gateway client APIs, third-party Gateway integrations
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: Weichen Xu <[email protected]>
@harupy
Copy link
Member

harupy commented Aug 23, 2023

@WeichenXu123 Looks like torch/utils/_pytree.py still exists:

https://github.com/pytorch/pytorch/blob/main/torch/utils/_pytree.py

@WeichenXu123
Copy link
Collaborator Author

@WeichenXu123 Looks like torch/utils/_pytree.py still exists:

https://github.com/pytorch/pytorch/blob/main/torch/utils/_pytree.py

But in torch 1.6 / 1.7 the module disappears. you can install it and test.

@harupy
Copy link
Member

harupy commented Aug 23, 2023

@WeichenXu123 Why did it disappear?

@WeichenXu123
Copy link
Collaborator Author

I checked again, I think 1.6/1.7 package is not changed and torch/utils/_pytree module never exists in these versions. I think it is because transformer package upgraded and it removes supporting for torch 1.6/1.7 @harupy

@harupy
Copy link
Member

harupy commented Aug 23, 2023

@WeichenXu123 Got it, then we can pin transformers.

@WeichenXu123
Copy link
Collaborator Author

@WeichenXu123 Got it, then we can pin transformers.

ok.

This reverts commit ebeb771.
Signed-off-by: Weichen Xu <[email protected]>
@mlflow-automation
Copy link
Collaborator

mlflow-automation commented Aug 23, 2023

Documentation preview for 3982a41 will be available here when this CircleCI job completes successfully.

More info

Signed-off-by: Weichen Xu <[email protected]>
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Weichen Xu <[email protected]>
@github-actions github-actions bot added area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs. labels Aug 23, 2023
@WeichenXu123 WeichenXu123 merged commit b00a06e into mlflow:master Aug 23, 2023
26 checks passed
clarkh-ncino pushed a commit to ncino/mlflow that referenced this pull request Aug 23, 2023
Signed-off-by: Weichen Xu <[email protected]>
Signed-off-by: Clark Hollar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build and test infrastructure for MLflow rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants