-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to Docker test environment #9432
Fixes to Docker test environment #9432
Conversation
Signed-off-by: Barry Hart <[email protected]>
Documentation preview for 5394b0e will be available here when this CircleCI job completes successfully. More info
|
Signed-off-by: Barry Hart <[email protected]>
Signed-off-by: Barry Hart <[email protected]>
RUN apt-get update && \ | ||
apt-get install -y --no-install-recommends build-essential openjdk-11-jre-headless \ | ||
apt-get install -y --no-install-recommends build-essential openjdk-17-jre-headless \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix: Version 11 package is no longer available.
rm $MINIFORG_FILENAME && \ | ||
rm $MINIFORG_FILENAME | ||
|
||
ADD ./requirements /app/requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build performance improvements:
- Move
ADD
commands later in the build. - For
pip install
, add only therequirements/
directory. - Split the single large
RUN
command into several smaller steps. This results in a larger image, but improves performance for incremental rebuilds by (in most cases) avoiding the need to rerunapt-get
or reinstall miniforge.
pip install -r requirements/test-requirements.txt --no-cache-dir \ | ||
-r requirements/lint-requirements.txt psutil | ||
|
||
ADD . /app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another performance improvement: Delay ADD .
until we need it for pip install -e .
.
# install required python packages | ||
pip install --no-cache-dir -r requirements/test-requirements.txt --no-cache-dir -r requirements/lint-requirements.txt && \ | ||
pip install -r requirements/test-requirements.txt --no-cache-dir \ | ||
-r requirements/lint-requirements.txt psutil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Install psutil
, which is used by tests/server/auth/test_auth.py
.
@@ -1,5 +1,7 @@ | |||
#!/usr/bin/env bash | |||
|
|||
set -euo pipefail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stop on failure. Otherwise, for example, if the image build fails, the container is still launched using an old image (confusing!).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Related Issues/PRs
n/aWhat changes are proposed in this pull request?
Improvements to
Dockerfile.test
andrun-test-container.sh
. These were first included in #9191, but it was suggested to move them to a separate PR. The Docker environment still has issues running tests due to some hardcoded default paths in themlflow
package itself. I have not attempted to fix those here, although that could be a future improvement.How is this patch tested?
Tested locally in the context of developing #9191.
Launched the Docker environment and used it to develop and test the changes in #9191.
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/gateway
: AI Gateway service, Gateway client APIs, third-party Gateway integrationsarea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes