Skip to content

Commit

Permalink
Merge pull request #309 from mlibrary/remove-load-js-for-current-chec…
Browse files Browse the repository at this point in the history
…kout

current-checkouts doesn't have js anymore
  • Loading branch information
niquerio authored Jul 30, 2024
2 parents 015ea14 + 608c2d1 commit 6e67060
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion lib/routes/current_checkouts.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
loan_controls = TableControls::LoansForm.new(limit: params["limit"], order_by: params["order_by"], direction: params["direction"])
loans = Loans.for(uniqname: session[:uniqname], offset: params["offset"], limit: params["limit"], order_by: params["order_by"], direction: params["direction"])
message = session.delete(:message)
erb :"current-checkouts/u-m-library", locals: {loans: loans, message: message, loan_controls: loan_controls, has_js: true}
erb :"current-checkouts/u-m-library", locals: {loans: loans, message: message, loan_controls: loan_controls}
rescue => e
flash.now[:error] = "<span class='strong'>Error:</span> We were unable to load your loans. Please try again." unless e.message == "not_in_alma"
erb :empty_state
Expand Down
4 changes: 0 additions & 4 deletions spec/requests/current_checkouts_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@
get "/current-checkouts/u-m-library"
expect(last_response.body).to include("U-M Library")
end
it "has checkouts js" do
get "/current-checkouts/u-m-library"
expect(last_response.body).to include("current-checkouts-u-m-library.bundle.js")
end
end
context "in alma user but alma has a network problem" do
it "loads the empty state and has an error flash" do
Expand Down

0 comments on commit 6e67060

Please sign in to comment.