Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve inspect/toString number formatter #157

Merged
merged 2 commits into from
Nov 5, 2022
Merged

Conversation

Dimava
Copy link
Contributor

@Dimava Dimava commented Nov 4, 2022

There was a corner case in inspect breaking the proper tabulation,
so I chose to rewrite the whole number formatter in a way I would like to see it to work.

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 66.67% // Head: 66.80% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (a8e3bcd) compared to base (4b8e9b7).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head a8e3bcd differs from pull request most recent head 3a621e7. Consider uploading reports for the commit 3a621e7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   66.67%   66.80%   +0.12%     
==========================================
  Files          32       32              
  Lines        3232     3241       +9     
  Branches      514      520       +6     
==========================================
+ Hits         2155     2165      +10     
+ Misses        997      996       -1     
  Partials       80       80              
Impacted Files Coverage Δ
src/inspect.js 100.00% <100.00%> (+3.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@targos targos merged commit 4ed872e into mljs:main Nov 5, 2022
@Dimava Dimava deleted the patch-2 branch November 5, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants