Remove notebook output logging.

Notebook output logging made it easier to test the logging console extension. I think it is too much noise for production, though, unless it is behind a option and turned off by default. See jupyterlab#7386
mlucool · Oct 22, 2019 · 0d4115d · 0d4115d
1 parent f34ca0d
commit 0d4115d
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 61 deletions.
diff --git a/packages/logconsole-extension/package.json b/packages/logconsole-extension/package.json
@@ -40,7 +40,6 @@
     "@jupyterlab/mainmenu": "^2.0.0-alpha.1",
     "@jupyterlab/notebook": "^2.0.0-alpha.1",
     "@jupyterlab/rendermime": "^2.0.0-alpha.1",
-    "@jupyterlab/services": "^5.0.0-alpha.1",
     "@jupyterlab/statusbar": "^2.0.0-alpha.1",
     "@jupyterlab/ui-components": "^2.0.0-alpha.1",
     "@phosphor/signaling": "^1.3.0",

diff --git a/packages/logconsole-extension/src/index.tsx b/packages/logconsole-extension/src/index.tsx
@@ -274,6 +274,4 @@ function activateLogConsole(
   return loggerRegistry;
 }
 
-// TODO: delete the nboutput widget, or at least make it a non-default option?
-import { logNotebookOutput } from './nboutput';
-export default [logConsolePlugin, logNotebookOutput];
+export default [logConsolePlugin];
diff --git a/packages/logconsole-extension/src/nboutput.ts b/packages/logconsole-extension/src/nboutput.ts
diff --git a/packages/logconsole-extension/tsconfig.json b/packages/logconsole-extension/tsconfig.json
@@ -27,9 +27,6 @@
     {
       "path": "../rendermime"
     },
-    {
-      "path": "../services"
-    },
     {
       "path": "../statusbar"
     },