Added fallback to atom icon when atom logo is missing (#221)

mmcdole · Feb 23, 2024 · b187685 · b187685
1 parent 38e4aa4
commit b187685
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 0 deletions.
diff --git a/testdata/translator/atom/feed_image_-_atom10_feed_icon.json b/testdata/translator/atom/feed_image_-_atom10_feed_icon.json
@@ -0,0 +1,8 @@
+{
+    "image": {
+        "url": "http://example.org/icon.jpg"
+    },
+    "items": [],
+    "feedType": "atom",
+    "feedVersion": "1.0"
+}
diff --git a/testdata/translator/atom/feed_image_-_atom10_feed_icon.xml b/testdata/translator/atom/feed_image_-_atom10_feed_icon.xml
@@ -0,0 +1,6 @@
+<!--
+Description: feed icon
+-->
+<feed xmlns="http://www.w3.org/2005/Atom">
+  <icon>http://example.org/icon.jpg</icon>
+</feed>
diff --git a/testdata/translator/atom/feed_image_-_atom10_feed_logo.xml b/testdata/translator/atom/feed_image_-_atom10_feed_logo.xml
@@ -3,4 +3,5 @@ Description: feed logo
 -->
 <feed xmlns="http://www.w3.org/2005/Atom">
   <logo>http://example.org/logo.jpg</logo>
+  <icon>http://example.org/icon.jpg</icon>
 </feed>
diff --git a/translator.go b/translator.go
@@ -613,6 +613,10 @@ func (t *DefaultAtomTranslator) translateFeedImage(atom *atom.Feed) (image *Imag
 		feedImage := Image{}
 		feedImage.URL = atom.Logo
 		image = &feedImage
+	} else if atom.Icon != "" {
+		feedImage := Image{}
+		feedImage.URL = atom.Icon
+		image = &feedImage
 	}
 	return
 }