Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gotypes: fix argument size for signatures without return types #212

Merged
merged 6 commits into from
Oct 30, 2021
Merged

gotypes: fix argument size for signatures without return types #212

merged 6 commits into from
Oct 30, 2021

Conversation

mmcloughlin
Copy link
Owner

Updates #191

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2021 •
edited
Loading

Codecov Report

Merging #212 (8fd6595) into master (e70c62b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   75.64%   75.65%           
=======================================
  Files          57       57           
  Lines       35121    35130    +9     
=======================================
+ Hits        26568    26577    +9     
  Misses       8400     8400           
  Partials      153      153
Flag Coverage Δ
integration 8.81% <100.00%> (+0.02%) ⬆️
unittests 73.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gotypes/signature.go 94.78% <100.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e70c62b...8fd6595. Read the comment docs.

@mmcloughlin mmcloughlin mentioned this pull request Oct 30, 2021
Closed
@mmcloughlin mmcloughlin changed the title tests: attempt to reproduce #191 gotypes: fix argument size for signatures without return types Oct 30, 2021
@mmcloughlin mmcloughlin marked this pull request as ready for review October 30, 2021 20:22
@mmcloughlin mmcloughlin merged commit 7de0251 into master Oct 30, 2021
@mmcloughlin mmcloughlin deleted the issue191 branch October 30, 2021 20:32
@mmcloughlin mmcloughlin mentioned this pull request Oct 30, 2021
Closed
mmcloughlin added a commit that referenced this pull request Oct 30, 2021
@mmcloughlin
gotypes,tests: test case for issue #195 (#214)
4f7179b 
Adds test cases for the bug in #195, similar to #212.

Updates #195
Updates #191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmcloughlin @codecov-commenter