Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip entire autoland job for non-bot users #382

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

mmcloughlin
Copy link
Owner

@mmcloughlin mmcloughlin commented Mar 6, 2023

In contributor PRs such as #372 we see that the pr/autoland job fails due to permissions issues obtaining an app token from a fork.

This job is actually only required to auto-land bot PRs. Instead of skipping just the auto-land setting step, we should be skipping the entire thing.

Fixes #381

@mmcloughlin mmcloughlin marked this pull request as ready for review March 6, 2023 04:24
@codecov-commenter
Copy link

Codecov Report

Merging #382 (40deebf) into master (759be3d) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #382   +/-   ##
=======================================
  Coverage   78.13%   78.13%           
=======================================
  Files          99       99           
  Lines       23724    23724           
=======================================
  Hits        18537    18537           
  Misses       5091     5091           
  Partials       96       96           
Flag Coverage Δ
integration 22.05% <ø> (ø)
unittests 73.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mmcloughlin mmcloughlin merged commit 5935b03 into master Mar 6, 2023
@mmcloughlin mmcloughlin deleted the ci-pr-autoland-only-bot-user branch March 6, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: contributor PRs fail the pr/automerge step
2 participants