-
Notifications
You must be signed in to change notification settings - Fork 25.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation warning with sass gem 3.5 #1114
Comments
If I had to guess it's due to one of the 3rd party mixins I'm using (Breakpoint, Susy, etc.). I'll see if I can track down which Sass partial is the issue and see if they have updated their libraries to get around the warnings. |
Investigate 3rd party Sass |
Found the culprit, Susy 2's set of mixins. These deprecation warnings are mostly harmless but figured I'd go ahead and upgrade to Susy 3 anyways. That project went through a fairly serious rewrite so I had to refactor a lot of the CSS I was using to build the theme's grid. Everything looks good to me, but if anyone wants to test and verify I didn't break anything (specifically grid layouts in related posts, galleries, etc) give it a go. To test you can replace the entire gem "minimal-mistakes-jekyll", :git => "https://github.com/mmistakes/minimal-mistakes.git", :branch => "susy-3-upgrade" |
…` functions Most of Susy's mixins have been deprecated, `@include container()`, `@include full()`, `@include span()`, `@include prefix()`, `@include suffix()`, `@include gallery()`, etc. Fixes mmistakes#1114
Merged updates from |
Great, thanks for confirming @wkc1986. I'll get this merged into the next release. |
using the specific susy-3-upgrade branch eliminated the warnings for me too. |
Good to hear @justinrummel. Kind of bummed with all the helper functions Susy removed with v3. All of the gallery mixins are gone which makes doing custom stuff a lot more involved. Especially for those who want to customize the columns. #623 #875 |
Fixed in 4ba7ccc |
…` functions Most of Susy's mixins have been deprecated, `@include container()`, `@include full()`, `@include span()`, `@include prefix()`, `@include suffix()`, `@include gallery()`, etc. Fixes mmistakes#1114
Trying to get rid of deprecation warnings as described here: mmistakes/minimal-mistakes#1114
…` functions Most of Susy's mixins have been deprecated, `@include container()`, `@include full()`, `@include span()`, `@include prefix()`, `@include suffix()`, `@include gallery()`, etc. Fixes mmistakes#1114
…` functions Most of Susy's mixins have been deprecated, `@include container()`, `@include full()`, `@include span()`, `@include prefix()`, `@include suffix()`, `@include gallery()`, etc. Fixes mmistakes#1114
…` functions Most of Susy's mixins have been deprecated, `@include container()`, `@include full()`, `@include span()`, `@include prefix()`, `@include suffix()`, `@include gallery()`, etc. Fixes mmistakes#1114
…akes#1114) Removing `.sh` from the executable file name
bundle update
.bundle exec jekyll build
.Environment informations
github-pages
orjekyll
gem version: (straight from forked source)Expected behavior
Site builds without warnings
Steps to reproduce the behavior
rm Gemfile.lock
bundle update
(updates saas gem to 3.5.1)
build site - causes screens full of the following warnings
DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal
in Sass 4.0. Use call(get-function("mixin-exists")) instead.
and
DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal
in Sass 4.0. Use call(get-function("variable-exists")) instead.
if I force the saas gem back to 3.4.25 - warnings disappear.
Unfortunately warnings don't reference the exact file names.
The text was updated successfully, but these errors were encountered: