Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve link posts #276

Closed
mmistakes opened this issue Apr 19, 2016 · 0 comments
Closed

Improve link posts #276

mmistakes opened this issue Apr 19, 2016 · 0 comments
Assignees
@mmistakes
Labels
Type: Enhancement

Comments

@mmistakes
Copy link
Owner

  • Include permalink anchored on the star and keep the post title linked to source.
  • Replace star icon with something better with more semantic meaning. Some sort of external link/share icon would be appropriate.
@mmistakes mmistakes self-assigned this Apr 19, 2016
mmistakes added a commit that referenced this issue Jul 11, 2016
@mmistakes
Improve link posts in archive listings
89a44dc 
- Remove `target="_blank"` anti-pattern
- If link post point title to source article
- Switch star icon to a link to indicate "permalink" and markup semantically with `rel="permalink"`
- Reduce opacity of permalink icon
- Adjust hover styles due to shuffling around <a> element
- Close #276
sobkowiak pushed a commit to sobkowiak/sobkowiak.github.io-new that referenced this issue Jul 18, 2016
@mmistakes @sobkowiak
Improve link posts in archive listings
248c1c2 
- Remove `target="_blank"` anti-pattern
- If link post point title to source article
- Switch star icon to a link to indicate "permalink" and markup semantically with `rel="permalink"`
- Reduce opacity of permalink icon
- Adjust hover styles due to shuffling around <a> element
- Close mmistakes#276
sobkowiak pushed a commit to sobkowiak/sobkowiak.github.io-new that referenced this issue Jul 18, 2016
@mmistakes @sobkowiak
Improve link posts in archive listings
d9b5d94 
- Remove `target="_blank"` anti-pattern
- If link post point title to source article
- Switch star icon to a link to indicate "permalink" and markup semantically with `rel="permalink"`
- Reduce opacity of permalink icon
- Adjust hover styles due to shuffling around <a> element
- Close mmistakes#276
cjmadsen pushed a commit to cjmadsen/cjmadsen.github.io that referenced this issue Dec 7, 2016
@gynter
Merge pull request mmistakes#276 from kuntoaji/master
0b932b6 
Add dekyll theme
jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this issue May 6, 2017
@jluccisano
Improve link posts in archive listings
092d2b5 
- Remove `target="_blank"` anti-pattern
- If link post point title to source article
- Switch star icon to a link to indicate "permalink" and markup semantically with `rel="permalink"`
- Reduce opacity of permalink icon
- Adjust hover styles due to shuffling around <a> element
- Close mmistakes#276
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this issue May 18, 2022
@makaroniame
Improve link posts in archive listings
fa8e0ff 
- Remove `target="_blank"` anti-pattern
- If link post point title to source article
- Switch star icon to a link to indicate "permalink" and markup semantically with `rel="permalink"`
- Reduce opacity of permalink icon
- Adjust hover styles due to shuffling around <a> element
- Close mmistakes#276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmistakes mmistakes

Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmistakes