Use css padding for author urls to fix underline hover state #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmistakes
requested changes
Mar 30, 2020
|
Makes sense. Pushed the fix. |
mmistakes
approved these changes
Mar 30, 2020
|
Looks good, thanks. |
|
@ali-farooq0 this bugged me for ages but I just today found the time to investigate this issue further. Now I found that you already created a PR. Thank you very much for that :) Can't wait for the next release. |
|
@d-Rickyy-b Anytime :). If you're using |
jesuswasrasta
pushed a commit
to jesuswasrasta/jesuswasrasta.github.io
that referenced
this pull request
Jul 8, 2020
…es#2472) * Use scss padding for sidebar author urls * rename .text to .label
mzaffran
pushed a commit
to mzaffran/mzaffran.github.io
that referenced
this pull request
Jan 4, 2021
…es#2472) * Use scss padding for sidebar author urls * rename .text to .label
kaitokikuchi
pushed a commit
to kaitokikuchi/kaitokikuchi.github.io
that referenced
this pull request
Sep 4, 2023
…es#2472) * Use scss padding for sidebar author urls * rename .text to .label
chukycheese
pushed a commit
to chukycheese/chukycheese.github.io
that referenced
this pull request
Sep 18, 2023
…es#2472) * Use scss padding for sidebar author urls * rename .text to .label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug (style) fix.
Summary
Author profile page uses a literal
This PR wraps the text with a
spanblock that can be used to customize spacing between the social icon and its relevant text, making it a breeze to customize as opposed to copyingauthor-profile.htmlto your local repo and customizing it just to fix spacing, making upgrading the theme very difficult.About page - BUG
With fixed spacing