Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sticky sidebar live well with short content #2514

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Make sticky sidebar live well with short content #2514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## Unreleased

### Enhancements

- Make sticky sidebar live well with short content. [#2514](https://github.com/mmistakes/minimal-mistakes/pull/2514)

## [4.19.2](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.19.2)

### Enhancements
Expand Down
2 changes: 1 addition & 1 deletion _sass/minimal-mistakes/_sidebar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
/* calculate height of nav list
viewport height - nav height - masthead x-padding
*/
height: calc(100vh - #{$nav-height} - 2em);
max-height: calc(100vh - #{$nav-height} - 2em);
}
}

Expand Down
8 changes: 7 additions & 1 deletion docs/_docs/18-history.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,16 @@ permalink: /docs/history/
excerpt: "Change log of enhancements and bug fixes made to the theme."
sidebar:
nav: docs
last_modified_at: 2020-05-01T11:53:42-04:00
last_modified_at: 2020-05-02T00:54:04+08:00
toc: false
---

## Unreleased

### Enhancements

- Make sticky sidebar live well with short content. [#2514](https://github.com/mmistakes/minimal-mistakes/pull/2514)

## [4.19.2](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.19.2)

### Enhancements
Expand Down