PCP-5: Improve the performance of WindowExec by using sliding windo…

…w or segment tree pingcap#12967 fix EvalReal
mmyj · Jan 1, 2020 · 9e14b03 · 9e14b03
1 parent 9cf1e1e
commit 9e14b03
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/executor/aggfuncs/func_count.go b/executor/aggfuncs/func_count.go
@@ -108,7 +108,7 @@ func (e *countOriginal4Real) UpdatePartialResult(sctx sessionctx.Context, rowsIn
 func (e *countOriginal4Real) Slide(sctx sessionctx.Context, rows []chunk.Row, lastStart, lastEnd uint64, shiftStart, shiftEnd uint64, pr PartialResult) error {
 	p := (*partialResult4Count)(pr)
 	for i := uint64(0); i < shiftStart; i++ {
-		_, isNull, err := e.args[0].EvalInt(sctx, rows[lastStart+i])
+		_, isNull, err := e.args[0].EvalReal(sctx, rows[lastStart+i])
 		if err != nil {
 			return err
 		}
@@ -118,7 +118,7 @@ func (e *countOriginal4Real) Slide(sctx sessionctx.Context, rows []chunk.Row, la
 		*p--
 	}
 	for i := uint64(0); i < shiftEnd; i++ {
-		_, isNull, err := e.args[0].EvalInt(sctx, rows[lastEnd+i])
+		_, isNull, err := e.args[0].EvalReal(sctx, rows[lastEnd+i])
 		if err != nil {
 			return err
 		}