-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] _part- -> _split- to conform with BIDS #417
Conversation
appveyor is green, so I trust that Travis will also be green soon. This is ready to be merged and then we can close this chapter :-) |
@@ -36,7 +36,7 @@ matrix: | |||
env: | |||
global: | |||
# can be "stable", or anything that can be used with git checkout | |||
- VALIDATOR_VERSION="8887074e5f5f48a768842ffcf96fb2952dbe0e38" | |||
- VALIDATOR_VERSION="e457907ca9af4c32aede828117ea5a43737b4597" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this random commit??! the stable branch doesn't yet work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bids-validator releases very often (sometimes even twice a week), so I find it more "stable" for us to regularly pin to an up to date commit.
that particular commit corresponds to my merge of the split
rules into the validator.
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
=======================================
Coverage 94.37% 94.37%
=======================================
Files 11 11
Lines 1528 1528
=======================================
Hits 1442 1442
Misses 86 86
Continue to review full report at Codecov.
|
Thanks @sappelhoff ! |
see: bids-standard/bids-specification#460
to be merged before CIs pass:
Merge checklist
Maintainer, please confirm the following before merging:
PR description includes phrase "closes <#issue-number>"