Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] _part- -> _split- to conform with BIDS #417

Merged
merged 6 commits into from
May 19, 2020

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented May 18, 2020

see: bids-standard/bids-specification#460

to be merged before CIs pass:

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"
  • Commit history does not contain any merge commits

doc/whats_new.rst Outdated Show resolved Hide resolved
@sappelhoff
Copy link
Member Author

appveyor is green, so I trust that Travis will also be green soon.

This is ready to be merged and then we can close this chapter :-)

@@ -36,7 +36,7 @@ matrix:
env:
global:
# can be "stable", or anything that can be used with git checkout
- VALIDATOR_VERSION="8887074e5f5f48a768842ffcf96fb2952dbe0e38"
- VALIDATOR_VERSION="e457907ca9af4c32aede828117ea5a43737b4597"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this random commit??! the stable branch doesn't yet work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bids-validator releases very often (sometimes even twice a week), so I find it more "stable" for us to regularly pin to an up to date commit.

that particular commit corresponds to my merge of the split rules into the validator.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #417 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files          11       11           
  Lines        1528     1528           
=======================================
  Hits         1442     1442           
  Misses         86       86           
Impacted Files Coverage Δ
mne_bids/utils.py 98.52% <ø> (ø)
mne_bids/write.py 97.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 102de3e...62a7e14. Read the comment docs.

@jasmainak jasmainak merged commit fb6e670 into mne-tools:master May 19, 2020
@jasmainak
Copy link
Member

Thanks @sappelhoff !

@sappelhoff sappelhoff deleted the part branch May 19, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants