-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time-domain asymmetric dynamical connectivity - data structure storage and basic OLS algorithms #150
Comments
Is there a replication we can do from one of these papers with real data available to make sure it works properly? |
Yep, I have these in the form of numpy arrays, with specific sliding windows and reference schemes. |
Great, I think this would be a good first thing to get going on when you get back if you want help |
Maybe it would be easier to start with the |
Some additional niceties that can come about: This can be useful for:
|
Maybe it would be good to start with repairing an epoch as an example and work backwards to all the functions needed to do that |
Is the proposal then to:
|
Yeah maybe we can pop in to talk to @larsoner to make sure this isn't redundant with anything or not helpful to add |
To bring this under a statistical framework and treat "repairing" of Epochs as a regression problem for out-of-sample using the "not-noisy" epochs as our training data, we can also see if it is possible to add some basic "model-selection" procedure using cross-validation That is for repairing noisy data:
|
Rough summary of off-GH discussion:
|
do you know about this https://scot-dev.github.io/scot-doc/index.html?
I am wondering if we should not move / consolidate the connectivity stuff
in a dedicated package outside
of mne-python. Personally I would recommend to use the
enveloppe correlation but the rest not sure.
Maybe we just need a convincing tutorial on a relevant dataset?
… |
I think it's Adam's project so he probably thinks we should all use it for all our connectivity needs ;) Looks really good but I do wonder if there aren't many ecog-specific connectivity methods that aren't better in a more generalized package although it does look as if We were talking about the other reasons for having good ieeg sample data so worth a try even if the good times of all connectivity methods accepted stop with us :) |
Related to just this PR, we simply want to expose tutorial of how to compute such things and how they might be useful in EEG/MEG/iEEG type analyses. As noted above, it has the added bonus of enabling dynamical system representations for "repairing" bad channel/epochs.
Downstream this would be useful imo, since it would lower cognitive load. I could see there being use for having a separate package altogether for "mne-connectivity", where things such as correlation, coherence are implemented. In addition, notions of dynamical systems (i.e. linear dynamical system) can be implemented as well. The only issue is that one of the main reasons I love mne is the consistency that I can get the "data" matched with "metadata" such as the I actually then wonder if something like mne-python can create a "DerivativeEEG" container that is analagous to |
let's try to chat it will be easier
|
Btw @alexrockhill spoke with @agramfort and he's opposed to adding this type of functionality into MNE-python. He thinks that it might be useful for a sub-group of us to try to band together w/
I'm pretty open to this idea if there's enough ppl game. However, for my purposes I really only use lds modeling... |
Additional notes, so I dont' forget: ask all people in scot/new connectivity indexes about forming into something like Incentive: paper? |
crossref to #50 and cc @cmista and @jshanna100 |
+100
… |
I'm not sure I understand all the technical details for this implementation, but, to me, this seems a bit like a 'thin'/single-function API that wouldn't be suitable in JOSS for instance. Maybe I am mistaken about the scope of the implementation though. There is somewhat of a precedent for gists that live outside of the package like the write edf function. Maybe there could be a bit of effort that I would be willing to help with/spearhead organizing these maybe somewhat like |
There is already https://github.com/mne-tools/mne-sandbox although it's been stagnant for a while... |
I would start from https://github.com/mne-tools/mne-project-template
and start putting there the various connectivity measure we have in
mne-python and elsewhere
after the first release of "mne-connectivity" we should start deprecating
the mne.connectivity module.
my 2c
… |
Describe the new feature or enhancement
This is related to a goal of mine to add generic "connectivity" function to MNE for the code-sprint.
Right now, there are a decent amount of "spectral connectivity" (possibly over time) metrics derived from raw EEG/MEG/iEEG data.There are alternative characterizations, such as dynamical system perspective, which models the data as:
where A is possibly an asymmetric matrix characterized by its eigenvalues. Note this is different then just looking at the "pearson correlation" (or covariances) over time, since correlation matrices are PSD and symmetric.
Since a linear dynamical system representation of the MEEG data is useful, it would be nice to have a "data structure" to store such a representation and also expose basic algorithms for estimating this model from the raw data. I'm opening this issue to have a discussion to see if this is feasible to add.
Describe your proposed implementation
One can leverage scikit-learn to add an option to say
Raw
, orEpochs
.One can add regularization as a result. The algorithm would essentially consist of a
window_size
andstep_size
, which takes a sliding window and estimates sequences of theseA
matrices.To make this a "nice" and "useful" workflow, I would argue that we need a:
Describe possible alternatives
In a related viewpoint, this is related to what is known as Dynamic Mode Decomposition (DMD), which is also useful, but the representation of the data is different, because there one is interested in not only the
A
matrix, but also the "DMD modes". This is related to the linear Koopman operator in dynamical systems theory; DMD is a finite approximation of Koopman.Example paper:
Additional comments
Example papers using
A
matrix:In addition https://arxiv.org/pdf/1802.08334.pdf talks about the convergence of such OLS estimates for A, giving some sort of theoretical guarantees on how "estimable" an A matrix is from MEEG data.
Comparisons to spectral connectivity
Spectral connectivity generally are defined as some correlation measure over frequency domain, and is generally symmetric. Here, I am proposing a
time-domain
and possibly ``asymmetric` "connectivity" derivative of the raw MEEG data.Testing
Datasets can be tested against A matrices I've computed using numpy.
The text was updated successfully, but these errors were encountered: