-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG, DOC, ENH: new frequency-tagging tutorial #8867
Conversation
thx @dominikwelke ! how big are the files? can we add this to the doc build to see it rendered on circleci? |
hi @agramfort, thanks for the quick response!
its about 40mb. i published the data on osf and the script fetches them from there
locally it builds fine. how do i add it to the doc build? |
if you call your tutorial plot_ssvep.py it will be automatically rendered on the website. thanks |
no files -> warnings -> docs won't build
Co-authored-by: kalenkovich <[email protected]>
By default, pyplot.stem draw stems starting from 0 which is not appropriate for SNR.
Using a stem plot is left as an option.
@rob-luke @agramfort the latest rendering is here: https://25353-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/time-freq/plot_ssvep.html @dominikwelke can you add a conditional like https://github.com/mne-tools/mne-python/blob/main/tools/circleci_download.sh#L90-L92 ? It would get rid of the download inside the example rendering. |
the conditional alone didnt work.. the ci sais |
Fun! We've hit another release-related error, as PyQt5 5.15.3 came out 3 hours ago: https://pypi.org/project/PyQt5/#history I'll make a hotfix in |
- automatic TOC
If you have all doc-building dependencies installed (e.g., with
it will build the docs plus your specific example. Locally when I do this on your branch and wait a few minutes for the built to complete I see: So clearly I got the syntax wrong. :) Changing it to:
and re-running |
it worked fine locally but stopped working with the new theme (
great. i actually wondered whether this would be correct, but i blindly trusted you :) |
Don't bother unless you can find one easily. Youve changed it to 15.0 now, so its clear to the reader. Thanks for the extra info. Its a great addition to the tutorials. |
Co-authored-by: Robert Luke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge when CIs are green (except the ones already red in main)
Thanks a lot @dominikwelke !
ok, all CIs are green @agramfort @larsoner @rob-luke @kalenkovich I'll push a last commit with the changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than two minor remaining issues, LGTM +1 for merge!
https://25558-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/time-freq/plot_ssvep.html
Co-authored-by: Eric Larson <[email protected]>
Committed your suggestions. |
@dominikwelke can you merge main branch here to make sure CIs are green? |
@agramfort all CIs are green now |
thx a lot @dominikwelke and @kalenkovich ! |
What does this implement/fix?
we propose a new tutorial for basic analysis of frequency-tagging data.
it comes with an example dataset from visual stimulation with inverting checkerboards.
Reference issue
no fixes, but loosely related to discussion about a new spectra class (#7671)
authors
@dominikwelke @kalenkovich