Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Fixes #134. Indicate how to load connectivity data from disk #135

Merged
merged 4 commits into from
Apr 2, 2023
Merged

[DOC] Fixes #134. Indicate how to load connectivity data from disk #135

merged 4 commits into from
Apr 2, 2023

Conversation

moritz-gerster
Copy link
Contributor

@moritz-gerster moritz-gerster commented Mar 31, 2023 •
edited
Loading

PR Description

It's just a simple hint to the function mne_connectivity.read_connectivity. Fixes #134.

I tried loading the data with all kinds of tools and did not succeed because I was not aware of this function.

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

adam2392
adam2392 reviewed Apr 2, 2023
View reviewed changes
mne_connectivity/base.py Outdated Show resolved Hide resolved
adam2392
adam2392 reviewed Apr 2, 2023
View reviewed changes
mne_connectivity/base.py Outdated Show resolved Hide resolved
adam2392
adam2392 approved these changes Apr 2, 2023
View reviewed changes
Copy link
Member

@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is fixed

@adam2392
Fix docstring
57d8228 
Signed-off-by: Adam Li <[email protected]>
@adam2392 adam2392 merged commit 1bfdf6d into mne-tools:main Apr 2, 2023
@moritz-gerster moritz-gerster deleted the update-doc branch April 3, 2023 10:51
tsbinns pushed a commit to tsbinns/mne-connectivity that referenced this pull request Dec 15, 2023
@moritz-gerster @adam2392
[DOC] Fixes mne-tools#134. Indicate how to load connectivity data fro…
124dc15 
…m disk (mne-tools#135)

---------

Signed-off-by: Adam Li <[email protected]>
Co-authored-by: Adam Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam2392 adam2392 adam2392 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear how to load connectivity object from disk after saving it
2 participants
@moritz-gerster @adam2392