Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing unit tests #172

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Conversation

tsbinns
Copy link
Collaborator

@tsbinns tsbinns commented Feb 5, 2024

Codestyle checks are failing due to benchmarks/bench_var.py and benchmarks/single_epoch_conn.py not being properly formatted. See e.g. #163, #171 for failing checks.

Have now run black on these files to hopefully fix things.

@larsoner
Copy link
Member

larsoner commented Feb 5, 2024

I think you're also hitting the pytest 8 warning catching change. For now can you try pinning to pytest<8? It should fix CIs

@tsbinns
Copy link
Collaborator Author

tsbinns commented Feb 5, 2024

Thanks for the suggestion @larsoner! That solved everything but the failing windows 3.11 unit tests:

ERROR: To modify pip, please run the following command:
C:\hostedtoolcache\windows\Python\3.11.7\x64\python.exe -m pip install --upgrade pip setuptools wheel

Have to admit I don't fully understand the difference between this suggestion and what is already being performed in workflows/unit_tests.yml:

pip install --upgrade pip setuptools wheel

@tsbinns tsbinns changed the title Fix bad formatting of benchmark files Fix failing unit tests Feb 5, 2024
@tsbinns
Copy link
Collaborator Author

tsbinns commented Feb 5, 2024

@larsoner Out of curiosity, do you have an idea what might have caused the windows check to suddenly start failing, and why this didn't affect the macos or ubuntu checks?

@larsoner
Copy link
Member

larsoner commented Feb 5, 2024

GitHub actions updates parts of their runner images from time to time. I'm guessing some recent update changed some file permissions. Windows has this weird thing where you have to do python -m pip ... rather than pip ... to get the right permissions to uninstall the old pip version sometimes, must have been one of those times!

@larsoner larsoner merged commit be17d09 into mne-tools:main Feb 5, 2024
11 checks passed
@tsbinns tsbinns deleted the pr-fix_failing_black branch February 5, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants