Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Add release workflow #198

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

tsbinns
Copy link
Collaborator

@tsbinns tsbinns commented Jun 4, 2024

@larsoner suggested in #181 to modernise publishing to PyPI with trusted artefact publishing on release.

Was suggested to use the MNE-BIDS-Pipeline workflow as a template and removing the username/password stuff: https://github.com/mne-tools/mne-bids-pipeline/blob/main/.github/workflows/release.yml

Haven't touched the existing publish_release.yml workflow. Very minor but wasn't sure if we should use this name, rename to release.yml, ygm.

Also had to add a new rule to the .yamllint.yml config for pre-commit yamllint check to pass on my windows machine due to unix vs. dos line endings.

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge but we'll need to wait for @adam2392 to make me an owner on PyPI, then we can set up trusted publishing and try it!

Thanks @tsbinns !

@larsoner larsoner merged commit 4d6a231 into mne-tools:main Jun 4, 2024
14 checks passed
@tsbinns tsbinns deleted the add_release_workflow branch June 12, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants