Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Revised connectivity examples, fixed some compilation errors with Qt6 and a missing include in the cmake files #967

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

johaenns
Copy link
Contributor

@johaenns johaenns commented Nov 6, 2023

  1. disp3d.qrc was missing in the disp3D cmake
  2. Including package OpenGLWidgets is required to properly compile on all platforms
  3. Using std in applicagtionlogger.cpp led to compile problems on some platforms and is not necessary.
  4. Revised connectivity examples to work properly.

@juangpc
Copy link
Collaborator

juangpc commented Nov 7, 2023

Great. Thanks.
Whenever you are ready, we could merge.

@johaenns
Copy link
Contributor Author

johaenns commented Nov 8, 2023

Hi Juan,

if you have no further comments - as far as I'm concerned it's good to go.

Best, Johannes

@juangpc juangpc merged commit 0d92e66 into mne-tools:main Nov 8, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants